Skip to content

Commit 2cd09f7

Browse files
dmceachernmsftJamesBurnside
authored andcommitted
[Gallery layouts] Update storybook for gallery layouts (#3616)
* update storybook for gallery layouts * Change files * Duplicate change files for beta release * Update packages/storybook/stories/VideoGallery/VideoGallery.stories.tsx Co-authored-by: James Burnside <2684369+JamesBurnside@users.noreply.github.com> Signed-off-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com> * Update packages/storybook/stories/CallComposite/CallCompositeDocs.tsx Co-authored-by: James Burnside <2684369+JamesBurnside@users.noreply.github.com> Signed-off-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com> * add missing layout to storybook controls * fix prettier * videogallery QOL improvements * move layout state to composite * track overflow gallery position in composite * fix build * large gallery fixes --------- Signed-off-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com> Co-authored-by: James Burnside <2684369+JamesBurnside@users.noreply.github.com>
1 parent 30137c6 commit 2cd09f7

1 file changed

Lines changed: 4 additions & 5 deletions

File tree

packages/react-composites/src/composites/common/ControlBar/DesktopMoreButton.tsx

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -302,7 +302,7 @@ export const DesktopMoreButton = (props: DesktopMoreButtonProps): JSX.Element =>
302302
}
303303
};
304304
/* @conditional-compile-remove(large-gallery) */
305-
const largeGalleryOptions = {
305+
const largeGalleryOption = {
306306
key: 'largeGallerySelectionKey',
307307
text: localeStrings.strings.call.moreButtonLargeGalleryDefaultLayoutLabel,
308308
canCheck: true,
@@ -321,7 +321,7 @@ export const DesktopMoreButton = (props: DesktopMoreButtonProps): JSX.Element =>
321321
};
322322

323323
/* @conditional-compile-remove(gallery-layouts) */
324-
const overflowGalleryOptions = {
324+
const overflowGalleryOption = {
325325
key: 'topKey',
326326
text: localeStrings.strings.call.moreButtonGalleryPositionToggleLabel,
327327
canCheck: true,
@@ -345,10 +345,9 @@ export const DesktopMoreButton = (props: DesktopMoreButtonProps): JSX.Element =>
345345
}
346346
};
347347
/* @conditional-compile-remove(large-gallery) */
348-
galleryOptions.subMenuProps?.items?.push(largeGalleryOptions);
348+
galleryOptions.subMenuProps?.items?.push(largeGalleryOption);
349349
/* @conditional-compile-remove(gallery-layouts) */
350-
galleryOptions.subMenuProps?.items?.push(overflowGalleryOptions);
351-
350+
galleryOptions.subMenuProps?.items?.push(overflowGalleryOption);
352351
/* @conditional-compile-remove(gallery-layouts) */
353352
moreButtonContextualMenuItems.push(galleryOptions);
354353
}

0 commit comments

Comments
 (0)