Skip to content

Commit 3cef06e

Browse files
Leah-Xia-Microsoftmgamis-msft
Leah-Xia-Microsoft
and
mgamis-msft
authored
[Beta-blocking] Fix speaker icon in contextual menu of microphone and devices button (#3294) (#3296)
* Fix speaker icon in contextual menu of microphone and devices button * Change files * Duplicate change log for beta * api changes * stable api changes Co-authored-by: mgamis-msft <79475487+mgamis-msft@users.noreply.github.com>
1 parent 48ddc4e commit 3cef06e

10 files changed

Lines changed: 25 additions & 2 deletions

File tree

‎change-beta/@azure-communication-react-f87ea73f-9fa4-4eb7-997c-9e51b1a2a966.json‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "none",
3+
"comment": "Fix speaker icon in contextual menu of microphone and devices button",
4+
"packageName": "@azure/communication-react",
5+
"email": "miguelgamis@microsoft.com",
6+
"dependentChangeType": "none"
7+
}

‎change/@azure-communication-react-f87ea73f-9fa4-4eb7-997c-9e51b1a2a966.json‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "none",
3+
"comment": "Fix speaker icon in contextual menu of microphone and devices button",
4+
"packageName": "@azure/communication-react",
5+
"email": "miguelgamis@microsoft.com",
6+
"dependentChangeType": "none"
7+
}

‎packages/communication-react/review/beta/communication-react.api.md‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2182,6 +2182,7 @@ export const DEFAULT_COMPONENT_ICONS: {
21822182
ChangeSpokenLanguageIcon: JSX.Element;
21832183
ContextMenuCameraIcon: JSX.Element;
21842184
ContextMenuMicIcon: JSX.Element;
2185+
ContextMenuSpeakerIcon: JSX.Element;
21852186
};
21862187

21872188
// @public
@@ -2296,6 +2297,7 @@ export const DEFAULT_COMPOSITE_ICONS: {
22962297
ChangeSpokenLanguageIcon: JSX.Element;
22972298
ContextMenuCameraIcon: JSX.Element;
22982299
ContextMenuMicIcon: JSX.Element;
2300+
ContextMenuSpeakerIcon: JSX.Element;
22992301
};
23002302

23012303
// @beta

‎packages/communication-react/review/stable/communication-react.api.md‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1501,6 +1501,7 @@ export const DEFAULT_COMPONENT_ICONS: {
15011501
SplitButtonPrimaryActionMicMuted: JSX.Element;
15021502
ContextMenuCameraIcon: JSX.Element;
15031503
ContextMenuMicIcon: JSX.Element;
1504+
ContextMenuSpeakerIcon: JSX.Element;
15041505
};
15051506

15061507
// @public
@@ -1580,6 +1581,7 @@ export const DEFAULT_COMPOSITE_ICONS: {
15801581
SplitButtonPrimaryActionMicMuted: JSX.Element;
15811582
ContextMenuCameraIcon: JSX.Element;
15821583
ContextMenuMicIcon: JSX.Element;
1584+
ContextMenuSpeakerIcon: JSX.Element;
15831585
};
15841586

15851587
// @public

‎packages/react-components/review/beta/react-components.api.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -787,6 +787,7 @@ export const DEFAULT_COMPONENT_ICONS: {
787787
ChangeSpokenLanguageIcon: JSX.Element;
788788
ContextMenuCameraIcon: JSX.Element;
789789
ContextMenuMicIcon: JSX.Element;
790+
ContextMenuSpeakerIcon: JSX.Element;
790791
};
791792

792793
// @internal

‎packages/react-components/review/stable/react-components.api.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -424,6 +424,7 @@ export const DEFAULT_COMPONENT_ICONS: {
424424
SplitButtonPrimaryActionMicMuted: JSX.Element;
425425
ContextMenuCameraIcon: JSX.Element;
426426
ContextMenuMicIcon: JSX.Element;
427+
ContextMenuSpeakerIcon: JSX.Element;
427428
};
428429

429430
// @internal

‎packages/react-components/src/components/DevicesButton.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -378,7 +378,7 @@ export const generateDefaultDeviceMenuProps = (
378378
styles: menuItemStyles
379379
},
380380
iconProps: {
381-
iconName: 'ContextMenuMicIcon',
381+
iconName: 'ContextMenuSpeakerIcon',
382382
styles: { root: { lineHeight: 0 } }
383383
},
384384
canCheck: true,

‎packages/react-components/src/theming/icons.tsx‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -331,5 +331,6 @@ export const DEFAULT_COMPONENT_ICONS = {
331331
/* @conditional-compile-remove(close-captions) */
332332
ChangeSpokenLanguageIcon: <PersonVoice20Regular />,
333333
ContextMenuCameraIcon: <Video20Regular />,
334-
ContextMenuMicIcon: <Mic20Regular />
334+
ContextMenuMicIcon: <Mic20Regular />,
335+
ContextMenuSpeakerIcon: <Speaker220Regular />
335336
};

‎packages/react-composites/review/beta/react-composites.api.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1292,6 +1292,7 @@ export const DEFAULT_COMPOSITE_ICONS: {
12921292
ChangeSpokenLanguageIcon: JSX.Element;
12931293
ContextMenuCameraIcon: JSX.Element;
12941294
ContextMenuMicIcon: JSX.Element;
1295+
ContextMenuSpeakerIcon: JSX.Element;
12951296
};
12961297

12971298
// @beta

‎packages/react-composites/review/stable/react-composites.api.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -919,6 +919,7 @@ export const DEFAULT_COMPOSITE_ICONS: {
919919
SplitButtonPrimaryActionMicMuted: JSX.Element;
920920
ContextMenuCameraIcon: JSX.Element;
921921
ContextMenuMicIcon: JSX.Element;
922+
ContextMenuSpeakerIcon: JSX.Element;
922923
};
923924

924925
// @public

0 commit comments

Comments
 (0)
⚡