Skip to content

Commit 3e67535

Browse files
Fix VideoTile menu button to show on hover when isSpeaking is true (#2721)
* Fix VideoTile menu button to show on hover when isSpeaking is true * Change files * Duplicate change files for beta release * change before element of VideoTIle to after element with pointer-evens set to none --------- Co-authored-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com>
1 parent d56e313 commit 3e67535

4 files changed

Lines changed: 20 additions & 8 deletions

File tree

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "patch",
3+
"comment": "Fix VideoTile to show menu button on hover when isSpeaking prop is true",
4+
"packageName": "@azure/communication-react",
5+
"email": "79475487+mgamis-msft@users.noreply.github.com",
6+
"dependentChangeType": "patch"
7+
}
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "patch",
3+
"comment": "Fix VideoTile to show menu button on hover when isSpeaking prop is true",
4+
"packageName": "@azure/communication-react",
5+
"email": "79475487+mgamis-msft@users.noreply.github.com",
6+
"dependentChangeType": "patch"
7+
}

packages/react-components/src/components/VideoGallery/FloatingLocalVideoLayout.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,6 +143,8 @@ export const FloatingLocalVideoLayout = (props: FloatingLocalVideoLayoutProps):
143143

144144
return (
145145
<Stack styles={rootLayoutStyle}>
146+
{wrappedLocalVideoComponent}
147+
<LayerHost id={layerHostId} className={mergeStyles(layerHostStyle)} />
146148
<Stack horizontal={false} styles={innerLayoutStyle} tokens={videoGalleryLayoutGap}>
147149
{screenShareComponent ? (
148150
screenShareComponent
@@ -153,8 +155,6 @@ export const FloatingLocalVideoLayout = (props: FloatingLocalVideoLayoutProps):
153155
)}
154156
{horizontalGallery}
155157
</Stack>
156-
{wrappedLocalVideoComponent}
157-
<LayerHost id={layerHostId} className={mergeStyles(layerHostStyle)} />
158158
</Stack>
159159
);
160160
};

packages/react-components/src/components/VideoTile.tsx

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -333,19 +333,17 @@ export const VideoTile = (props: VideoTileProps): JSX.Element => {
333333
rootStyles,
334334
{
335335
background: theme.palette.neutralLighter,
336-
borderRadius: theme.effects.roundedCorner4,
337-
// To ensure that the video tile is focusable when there is a floating video tile
338-
zIndex: 1
336+
borderRadius: theme.effects.roundedCorner4
339337
},
340338
isSpeaking && {
341-
'&::before': {
339+
'&::after': {
342340
content: `''`,
343341
position: 'absolute',
344-
zIndex: 1,
345342
border: `0.25rem solid ${theme.palette.themePrimary}`,
346343
borderRadius: theme.effects.roundedCorner4,
347344
width: '100%',
348-
height: '100%'
345+
height: '100%',
346+
pointerEvents: 'none'
349347
}
350348
},
351349
styles?.root

0 commit comments

Comments
 (0)