Skip to content

Commit 5615022

Browse files
edwardlee-msftpull[bot]
authored andcommitted
[bugfix] Center incoming call toast and modal button icons (#2386)
* Center incoming call toast button icons * Center incoming call modal footer buttons
1 parent 666f936 commit 5615022

5 files changed

Lines changed: 24 additions & 112 deletions

File tree

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "patch",
3+
"comment": "Center incoming call toast button icons",
4+
"packageName": "@internal/storybook",
5+
"email": "edwardlee@microsoft.com",
6+
"dependentChangeType": "patch"
7+
}

packages/storybook/stories/CallComposite/components/IncomingCallAlert.tsx

Lines changed: 0 additions & 103 deletions
This file was deleted.

packages/storybook/stories/CallComposite/components/SimpleInboundHomeScreen.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,7 @@ import { CommunicationUserIdentifier } from '@azure/communication-common';
66
import { CallClientState } from '@azure/communication-react';
77
import { Stack, Text, TextField, IStackTokens, mergeStyles } from '@fluentui/react';
88
import React, { useEffect, useRef, useState } from 'react';
9-
10-
import { IncomingCallToast } from './IncomingCallAlert';
9+
import { IncomingCallToast } from '../../Examples/IncomingCallAlerts/components';
1110

1211
export interface HomeScreenProps {
1312
callState: CallClientState;

packages/storybook/stories/Examples/IncomingCallAlerts/components/IncomingCallAlerts.tsx

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@ import {
1212
incomingCallToastAvatarContainerStyle,
1313
incomingCallToastStyle,
1414
incomingCallModalLocalPreviewStyle,
15-
incomingCallModalContainerStyle
15+
incomingCallModalContainerStyle,
16+
incomingCallModalDialogFooterStyle
1617
} from './styles/IncomingCallAlerts.styles';
1718

1819
export type IncomingCallToastProps = {
@@ -57,12 +58,12 @@ export const IncomingCallToast = (props: IncomingCallToastProps): JSX.Element =>
5758
<DefaultButton
5859
className={incomingCallRejectButtonStyle}
5960
onClick={() => onClickReject()}
60-
onRenderIcon={() => <CallEnd20Filled />}
61+
onRenderIcon={() => <CallEnd20Filled style={{ display: 'flex' }} />}
6162
/>
6263
<DefaultButton
6364
className={incomingCallAcceptButtonStyle}
6465
onClick={() => onClickAccept()}
65-
onRenderIcon={() => <Call20Filled />}
66+
onRenderIcon={() => <Call20Filled style={{ display: 'flex' }} />}
6667
/>
6768
</Stack>
6869
</Stack>
@@ -153,15 +154,15 @@ export const IncomingCallModal = (props: IncomingCallModalProps): JSX.Element =>
153154
<Stack className={incomingCallModalLocalPreviewStyle}>{mediaGalleryLocalParticipant}</Stack>
154155
) : null}
155156

156-
<DialogFooter>
157+
<DialogFooter styles={incomingCallModalDialogFooterStyle}>
157158
<DefaultButton
158159
style={{ background: palette.neutralLighterAlt, border: 'none' }}
159160
onClick={() => onClickVideoToggle()}
160161
onRenderIcon={() =>
161162
showLocalVideo ? (
162-
<Video20Filled primaryFill="currentColor" />
163+
<Video20Filled primaryFill="currentColor" style={{ display: 'flex' }} />
163164
) : (
164-
<VideoOff20Filled primaryFill="currentColor" />
165+
<VideoOff20Filled primaryFill="currentColor" style={{ display: 'flex' }} />
165166
)
166167
}
167168
/>

packages/storybook/stories/Examples/IncomingCallAlerts/components/styles/IncomingCallAlerts.styles.ts

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// Copyright (c) Microsoft Corporation.
22
// Licensed under the MIT license.
33

4-
import { getTheme, mergeStyles } from '@fluentui/react';
4+
import { getTheme, IDialogFooterStyles, mergeStyles } from '@fluentui/react';
55
const theme = getTheme();
66
const palette = theme.palette;
77

@@ -61,3 +61,11 @@ export const incomingCallModalLocalPreviewStyle = mergeStyles({
6161
borderRadius: '0.25rem'
6262
}
6363
});
64+
65+
export const incomingCallModalDialogFooterStyle: IDialogFooterStyles = {
66+
action: {},
67+
actions: {},
68+
actionsRight: {
69+
display: 'flex'
70+
}
71+
};

0 commit comments

Comments
 (0)