Skip to content

Commit 5dd1c66

Browse files
update onCancelMessageEdit to onCancelEditMessage for 1.6.0 release (#3244)
1 parent d4393ab commit 5dd1c66

9 files changed

Lines changed: 32 additions & 18 deletions

File tree

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "none",
3+
"comment": "update onCancelMessageEdit to onCancelEditMessage for 1.6.0 release",
4+
"packageName": "@azure/communication-react",
5+
"email": "2684369+JamesBurnside@users.noreply.github.com",
6+
"dependentChangeType": "none"
7+
}
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "none",
3+
"comment": "update onCancelMessageEdit to onCancelEditMessage for 1.6.0 release",
4+
"packageName": "@azure/communication-react",
5+
"email": "2684369+JamesBurnside@users.noreply.github.com",
6+
"dependentChangeType": "none"
7+
}

packages/communication-react/review/beta/communication-react.api.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2822,7 +2822,7 @@ export type MessageProps = {
28222822
showDate?: boolean;
28232823
disableEditing?: boolean;
28242824
onUpdateMessage?: UpdateMessageCallback;
2825-
onCancelMessageEdit?: CancelEditCallback;
2825+
onCancelEditMessage?: CancelEditCallback;
28262826
onDeleteMessage?: (messageId: string) => Promise<void>;
28272827
onSendMessage?: (messageId: string) => Promise<void>;
28282828
};
@@ -2898,7 +2898,7 @@ export type MessageThreadProps = {
28982898
onRenderFileDownloads?: (userId: string, message: ChatMessage) => JSX.Element;
28992899
onFetchAttachments?: (attachment: FileMetadata) => Promise<AttachmentDownloadResult[]>;
29002900
onUpdateMessage?: UpdateMessageCallback;
2901-
onCancelMessageEdit?: CancelEditCallback;
2901+
onCancelEditMessage?: CancelEditCallback;
29022902
onDeleteMessage?: (messageId: string) => Promise<void>;
29032903
onSendMessage?: (content: string) => Promise<void>;
29042904
disableEditing?: boolean;

packages/communication-react/review/stable/communication-react.api.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1902,7 +1902,7 @@ export type MessageProps = {
19021902
showDate?: boolean;
19031903
disableEditing?: boolean;
19041904
onUpdateMessage?: UpdateMessageCallback;
1905-
onCancelMessageEdit?: CancelEditCallback;
1905+
onCancelEditMessage?: CancelEditCallback;
19061906
onDeleteMessage?: (messageId: string) => Promise<void>;
19071907
onSendMessage?: (messageId: string) => Promise<void>;
19081908
};
@@ -1976,7 +1976,7 @@ export type MessageThreadProps = {
19761976
onLoadPreviousChatMessages?: (messagesToLoad: number) => Promise<boolean>;
19771977
onRenderMessage?: (messageProps: MessageProps, messageRenderer?: MessageRenderer) => JSX.Element;
19781978
onUpdateMessage?: UpdateMessageCallback;
1979-
onCancelMessageEdit?: CancelEditCallback;
1979+
onCancelEditMessage?: CancelEditCallback;
19801980
onDeleteMessage?: (messageId: string) => Promise<void>;
19811981
onSendMessage?: (content: string) => Promise<void>;
19821982
disableEditing?: boolean;

packages/react-components/review/beta/react-components.api.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1329,7 +1329,7 @@ export type MessageProps = {
13291329
showDate?: boolean;
13301330
disableEditing?: boolean;
13311331
onUpdateMessage?: UpdateMessageCallback;
1332-
onCancelMessageEdit?: CancelEditCallback;
1332+
onCancelEditMessage?: CancelEditCallback;
13331333
onDeleteMessage?: (messageId: string) => Promise<void>;
13341334
onSendMessage?: (messageId: string) => Promise<void>;
13351335
};
@@ -1388,7 +1388,7 @@ export type MessageThreadProps = {
13881388
onRenderFileDownloads?: (userId: string, message: ChatMessage) => JSX.Element;
13891389
onFetchAttachments?: (attachment: FileMetadata) => Promise<AttachmentDownloadResult[]>;
13901390
onUpdateMessage?: UpdateMessageCallback;
1391-
onCancelMessageEdit?: CancelEditCallback;
1391+
onCancelEditMessage?: CancelEditCallback;
13921392
onDeleteMessage?: (messageId: string) => Promise<void>;
13931393
onSendMessage?: (content: string) => Promise<void>;
13941394
disableEditing?: boolean;

packages/react-components/review/stable/react-components.api.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -880,7 +880,7 @@ export type MessageProps = {
880880
showDate?: boolean;
881881
disableEditing?: boolean;
882882
onUpdateMessage?: UpdateMessageCallback;
883-
onCancelMessageEdit?: CancelEditCallback;
883+
onCancelEditMessage?: CancelEditCallback;
884884
onDeleteMessage?: (messageId: string) => Promise<void>;
885885
onSendMessage?: (messageId: string) => Promise<void>;
886886
};
@@ -937,7 +937,7 @@ export type MessageThreadProps = {
937937
onLoadPreviousChatMessages?: (messagesToLoad: number) => Promise<boolean>;
938938
onRenderMessage?: (messageProps: MessageProps, messageRenderer?: MessageRenderer) => JSX.Element;
939939
onUpdateMessage?: UpdateMessageCallback;
940-
onCancelMessageEdit?: CancelEditCallback;
940+
onCancelEditMessage?: CancelEditCallback;
941941
onDeleteMessage?: (messageId: string) => Promise<void>;
942942
onSendMessage?: (content: string) => Promise<void>;
943943
disableEditing?: boolean;

packages/react-components/src/components/ChatMessage/ChatMessageComponent.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ type ChatMessageComponentProps = {
2727
attachedFilesMetadata?: FileMetadata[];
2828
}
2929
) => Promise<void>;
30-
onCancelMessageEdit?: (messageId: string) => void;
30+
onCancelEditMessage?: (messageId: string) => void;
3131
/**
3232
* Callback to delete a message. Also called before resending a message that failed to send.
3333
* @param messageId ID of the message to delete
@@ -135,7 +135,7 @@ export const ChatMessageComponent = (props: ChatMessageComponentProps): JSX.Elem
135135
setIsEditing(false);
136136
}}
137137
onCancel={(messageId) => {
138-
props.onCancelMessageEdit && props.onCancelMessageEdit(messageId);
138+
props.onCancelEditMessage && props.onCancelEditMessage(messageId);
139139
setIsEditing(false);
140140
}}
141141
/* @conditional-compile-remove(mention) */

packages/react-components/src/components/MessageThread.tsx

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -371,7 +371,7 @@ const memoizeAllMessages = memoizeFnAll(
371371
readCount?: number,
372372
onRenderMessage?: (message: MessageProps, defaultOnRender?: MessageRenderer) => JSX.Element,
373373
onUpdateMessage?: UpdateMessageCallback,
374-
onCancelMessageEdit?: CancelEditCallback,
374+
onCancelEditMessage?: CancelEditCallback,
375375
onDeleteMessage?: (messageId: string) => Promise<void>,
376376
onSendMessage?: (content: string) => Promise<void>,
377377
disableEditing?: boolean
@@ -381,7 +381,7 @@ const memoizeAllMessages = memoizeFnAll(
381381
strings,
382382
showDate: showMessageDate,
383383
onUpdateMessage,
384-
onCancelMessageEdit,
384+
onCancelEditMessage,
385385
onDeleteMessage,
386386
onSendMessage,
387387
disableEditing
@@ -658,7 +658,7 @@ export type MessageThreadProps = {
658658
*
659659
* @param messageId - message id from chatClient
660660
*/
661-
onCancelMessageEdit?: CancelEditCallback;
661+
onCancelEditMessage?: CancelEditCallback;
662662
/**
663663
* Optional callback to delete a message.
664664
*
@@ -760,7 +760,7 @@ export type MessageProps = {
760760
*
761761
* @param messageId - message id from chatClient
762762
*/
763-
onCancelMessageEdit?: CancelEditCallback;
763+
onCancelEditMessage?: CancelEditCallback;
764764
/**
765765
* Optional callback to delete a message.
766766
*
@@ -807,7 +807,7 @@ export const MessageThread = (props: MessageThreadProps): JSX.Element => {
807807
onRenderJumpToNewMessageButton,
808808
onRenderMessage,
809809
onUpdateMessage,
810-
onCancelMessageEdit,
810+
onCancelEditMessage,
811811
onDeleteMessage,
812812
onSendMessage,
813813
/* @conditional-compile-remove(date-time-customization) */
@@ -1247,7 +1247,7 @@ export const MessageThread = (props: MessageThreadProps): JSX.Element => {
12471247
readCountForHoveredIndicator,
12481248
onRenderMessage,
12491249
onUpdateMessage,
1250-
onCancelMessageEdit,
1250+
onCancelEditMessage,
12511251
onDeleteMessage,
12521252
onSendMessage,
12531253
props.disableEditing
@@ -1270,7 +1270,7 @@ export const MessageThread = (props: MessageThreadProps): JSX.Element => {
12701270
readCountForHoveredIndicator,
12711271
onRenderMessage,
12721272
onUpdateMessage,
1273-
onCancelMessageEdit,
1273+
onCancelEditMessage,
12741274
onDeleteMessage,
12751275
onSendMessage,
12761276
lastSeenChatMessage,

packages/storybook/stories/MessageThread/snippets/Default.snippet.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ export const DefaultMessageThreadExample: () => JSX.Element = () => {
1919
setMessages(updated);
2020
return Promise.reject('Failed to update');
2121
}}
22-
onCancelMessageEdit={(id) => {
22+
onCancelEditMessage={(id) => {
2323
const updated = messages.map((m) =>
2424
m.messageId === id ? { ...m, failureReason: undefined, status: undefined } : m
2525
);

0 commit comments

Comments
 (0)