Skip to content

Commit 65a2aa9

Browse files
dmceachernmsftcarocao-msft
authored andcommitted
[A11y bugfix] Allow voice controls to action people button in Call and CallWithChat (#2833)
* update aria strings for people button * fix ??? * Change files * Duplicate change files for beta release
1 parent dbcf2b0 commit 65a2aa9

5 files changed

Lines changed: 17 additions & 1 deletion

File tree

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "patch",
3+
"comment": "Update Aria labels for people button to allow for voice access controls on windows.",
4+
"packageName": "@azure/communication-react",
5+
"email": "94866715+dmceachernmsft@users.noreply.github.com",
6+
"dependentChangeType": "patch"
7+
}

change/@azure-communication-react-696ca73a-856e-4a9a-97e4-b6b66b3099b4.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"type": "pre-release",
2+
"type": "prerelease",
33
"comment": "Video Effects Button and Pane",
44
"packageName": "@azure/communication-react",
55
"email": "97124699+prabhjot-msft@users.noreply.github.com",
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "patch",
3+
"comment": "Update Aria labels for people button to allow for voice access controls on windows.",
4+
"packageName": "@azure/communication-react",
5+
"email": "94866715+dmceachernmsft@users.noreply.github.com",
6+
"dependentChangeType": "patch"
7+
}

packages/react-composites/src/composites/CallComposite/components/CallControls.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -247,6 +247,7 @@ export const CallControls = (props: CallControlsProps & ContainerRectProps): JSX
247247
/* @conditional-compile-remove(one-to-n-calling) */ /* @conditional-compile-remove(PSTN-calls) */
248248
<People
249249
checked={props.peopleButtonChecked}
250+
ariaLabel={peopleButtonStrings?.label}
250251
showLabel={options?.displayType !== 'compact'}
251252
onClick={props.onPeopleButtonClicked}
252253
data-ui-id="call-composite-people-button"

packages/react-composites/src/composites/CallWithChatComposite/CallWithChatControlBar.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -273,6 +273,7 @@ export const CallWithChatControlBar = (props: CallWithChatControlBarProps & Cont
273273
{isEnabled(options?.peopleButton) && (
274274
<PeopleButton
275275
checked={props.peopleButtonChecked}
276+
ariaLabel={peopleButtonStrings?.label}
276277
showLabel={options.displayType !== 'compact'}
277278
onClick={props.onPeopleButtonClicked}
278279
data-ui-id="call-with-chat-composite-people-button"

0 commit comments

Comments
 (0)