[Bugfix] CallAdapter id checking (#3972)

* add mocks (not working)

* add throw conditions to wrong kinds of identifiers passed to create

* Change files

* Duplicate change files for beta release

* fix cc

* Update packages/react-composites/src/composites/CallComposite/adapter/AzureCommunicationCallAdapter.ts

Co-authored-by: James Burnside <2684369+JamesBurnside@users.noreply.github.com>
Signed-off-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com>

* oops

* oops2

* fix audio context sound testing

---------

Signed-off-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com>
Co-authored-by: James Burnside <2684369+JamesBurnside@users.noreply.github.com>

Author: dmceachernmsft

change-beta/@azure-communication-react-a79595ca-bfaa-49a2-9a05-7e9549d6f012.json

@@ -0,0 +1,9 @@
+{
+  "type": "patch",
+  "area": "fix",
+  "workstream": "Bugfix",
+  "comment": "Introduce blocking error when giving wrong kind of identifier to createAzureCommunicationCallAdapter",
+  "packageName": "@azure/communication-react",
+  "email": "94866715+dmceachernmsft@users.noreply.github.com",
+  "dependentChangeType": "patch"
+}

change/@azure-communication-react-a79595ca-bfaa-49a2-9a05-7e9549d6f012.json

@@ -0,0 +1,9 @@
+{
+  "type": "patch",
+  "area": "fix",
+  "workstream": "Bugfix",
+  "comment": "Introduce blocking error when giving wrong kind of identifier to createAzureCommunicationCallAdapter",
+  "packageName": "@azure/communication-react",
+  "email": "94866715+dmceachernmsft@users.noreply.github.com",
+  "dependentChangeType": "patch"
+}

packages/react-composites/src/composites/CallComposite/adapter/AzureCommunicationCallAdapter.ts

@@ -98,14 +98,13 @@ import {
   CommunicationTokenCredential,
   CommunicationUserIdentifier,
   CommunicationIdentifier,
-  MicrosoftTeamsUserIdentifier
+  MicrosoftTeamsUserIdentifier,
+  isMicrosoftTeamsUserIdentifier
 } from '@azure/communication-common';
+/* @conditional-compile-remove(teams-identity-support) */ /* @conditional-compile-remove(PSTN-calls) */
+import { isCommunicationUserIdentifier } from '@azure/communication-common';
 /* @conditional-compile-remove(PSTN-calls) */
-import {
-  isCommunicationUserIdentifier,
-  isPhoneNumberIdentifier,
-  PhoneNumberIdentifier
-} from '@azure/communication-common';
+import { isPhoneNumberIdentifier, PhoneNumberIdentifier } from '@azure/communication-common';
 import { ParticipantSubscriber } from './ParticipantSubcriber';
 import { AdapterError } from '../../common/adapters';
 import { DiagnosticsForwarder } from './DiagnosticsForwarder';
@@ -1452,6 +1451,11 @@ export const createAzureCommunicationCallAdapter = async ({
   /* @conditional-compile-remove(PSTN-calls) */ alternateCallerId,
   /* @conditional-compile-remove(video-background-effects) */ options
 }: AzureCommunicationCallAdapterArgs): Promise<CallAdapter> => {
+  if (isMicrosoftTeamsUserIdentifier(userId)) {
+    throw new Error(
+      'Microsoft Teams user identifier is not supported by AzureCommunicationCallAdapter. Instead use TeamsCallAdapter.'
+    );
+  }
   return _createAzureCommunicationCallAdapterInner({
     userId,
     displayName,
@@ -1521,6 +1525,11 @@ export const createTeamsCallAdapter = async ({
   locator,
   options
 }: TeamsCallAdapterArgs): Promise<TeamsCallAdapter> => {
+  if (isCommunicationUserIdentifier(userId)) {
+    throw new Error(
+      'Communication User identifier is not supported by TeamsCallAdapter, please use our AzureCommunicationCallAdapter.'
+    );
+  }
   const callClient = _createStatefulCallClientInner(
     {
       userId