Enable noImplicitAny in chat-stateful-client (#3998)

Author: emlynmac

change-beta/@azure-communication-react-dc493c99-51c2-4422-8b96-4bdff0edb5ca.json

@@ -0,0 +1,9 @@
+{
+  "type": "patch",
+  "area": "fix",
+  "workstream": "noImplicitAny fixes",
+  "comment": "Enable noImplicitAny in chat-component-bindings",
+  "packageName": "@azure/communication-react",
+  "email": "3941071+emlynmac@users.noreply.github.com",
+  "dependentChangeType": "patch"
+}

change/@azure-communication-react-dc493c99-51c2-4422-8b96-4bdff0edb5ca.json

@@ -0,0 +1,9 @@
+{
+  "type": "patch",
+  "area": "fix",
+  "workstream": "noImplicitAny fixes",
+  "comment": "Enable noImplicitAny in chat-component-bindings",
+  "packageName": "@azure/communication-react",
+  "email": "3941071+emlynmac@users.noreply.github.com",
+  "dependentChangeType": "patch"
+}

packages/chat-component-bindings/src/errorBarSelector.ts

@@ -95,13 +95,15 @@ const accessErrorTargets: ChatErrorTarget[] = [
 
 const latestUnableToReachChatServiceError = (latestErrors: ChatErrors): ActiveErrorMessage | undefined => {
   return latestActiveErrorSatisfying(latestErrors, 'unableToReachChatService', (error: ChatError): boolean => {
-    return !!error && !!error.innerError && error.innerError['code'] === 'REQUEST_SEND_ERROR';
+    return (
+      !!error && !!error.innerError && 'code' in error.innerError && error.innerError.code === 'REQUEST_SEND_ERROR'
+    );
   });
 };
 
 const latestAccessDeniedError = (latestErrors: ChatErrors): ActiveErrorMessage | undefined => {
   return latestActiveErrorSatisfying(latestErrors, 'accessDenied', (error: ChatError): boolean => {
-    return !!error && !!error.innerError && error.innerError['statusCode'] === 401;
+    return !!error && !!error.innerError && 'statusCode' in error.innerError && error.innerError.statusCode === 401;
   });
 };
 
@@ -121,13 +123,16 @@ const latestNotInThisThreadError = (latestErrors: ChatErrors): ActiveErrorMessag
 
     // Chat service returns 403 if a user has been removed from a thread.
     // Chat service returns either 400 or 404 if the thread ID is malformed, depending on how the thread ID is malformed.
-    return [400, 403, 404].some((statusCode) => error.innerError['statusCode'] === statusCode);
+    return [400, 403, 404].some(
+      (statusCode) => 'statusCode' in error.innerError && error.innerError.statusCode === statusCode
+    );
   });
 };
 
 const botContactMRIPrefix = '28:';
 const isErrorDueToBotContact = (error: ChatError): boolean =>
-  error.innerError['statusCode'] === 400 &&
+  'statusCode' in error.innerError &&
+  error.innerError.statusCode === 400 &&
   error.innerError.message.includes(`Identifier format is not supported (${botContactMRIPrefix}`);
 
 const latestActiveErrorSatisfying = (

packages/chat-component-bindings/src/hooks/usePropsFor.ts

@@ -80,7 +80,7 @@ export const getSelector = <Component extends (props: any) => JSX.Element | unde
   return findSelector(component);
 };
 
-const messageThreadSelectorsByThread = {};
+const messageThreadSelectorsByThread: { [key: string]: MessageThreadSelector } = {};
 
 const findSelector = (component: (props: any) => JSX.Element | undefined): any => {
   // For the message thread selector we need to create a new one for each thread

packages/chat-component-bindings/src/typingIndicatorSelector.test.ts

@@ -206,7 +206,7 @@ describe('typingIndicatorSelector tests', () => {
         receivedOn: new Date()
       }
     ];
-    const participants = {};
+    const participants: { [key: number]: { id: string; displayName: string } } = {};
     Array.from(Array(20).keys()).forEach(
       (num) => (participants[`${num}`] = { id: `${num}`, displayName: `User${num}` })
     );

packages/chat-component-bindings/tsconfig.json

@@ -1,7 +1,6 @@
 {
   "extends": "../../common/config/tsc/tsconfig.json",
   "compilerOptions": {
-    "noImplicitAny": false, // TODO: MAKE THIS true
     "outDir": "./dist/dist-esm"
   },
   "typeRoots": ["./node_modules/@types"],