Skip to content

Commit 74a97ba

Browse files
[Chat] Remove file card group message from stable API (#3940)
* Remove FileCardGroupMessage From Stable API * Change files * Duplicate change files for beta release * Update packages/react-components/src/components/FileDownloadCards.tsx Co-authored-by: JoshuaLai <9044372+JoshuaLai@users.noreply.github.com> Signed-off-by: Leah Xia <107075081+Leah-Xia-Microsoft@users.noreply.github.com> * Revert "Update packages/react-components/src/components/FileDownloadCards.tsx" This reverts commit 670dca6. --------- Signed-off-by: Leah Xia <107075081+Leah-Xia-Microsoft@users.noreply.github.com>
1 parent 98b9f7d commit 74a97ba

6 files changed

Lines changed: 24 additions & 5 deletions

File tree

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
{
2+
"type": "minor",
3+
"area": "improvement",
4+
"workstream": "InlineImageGA",
5+
"comment": "Remove FileCardGroupMessage From Stable API",
6+
"packageName": "@azure/communication-react",
7+
"email": "107075081+Leah-Xia-Microsoft@users.noreply.github.com",
8+
"dependentChangeType": "patch"
9+
}
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
{
2+
"type": "minor",
3+
"area": "improvement",
4+
"workstream": "InlineImageGA",
5+
"comment": "Remove FileCardGroupMessage From Stable API",
6+
"packageName": "@azure/communication-react",
7+
"email": "107075081+Leah-Xia-Microsoft@users.noreply.github.com",
8+
"dependentChangeType": "patch"
9+
}

packages/communication-react/review/stable/communication-react.api.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2568,7 +2568,6 @@ export interface MessageThreadStrings {
25682568
editedTag: string;
25692569
editMessage: string;
25702570
failToSendTag?: string;
2571-
fileCardGroupMessage: string;
25722571
friday: string;
25732572
liveAuthorIntro: string;
25742573
messageContentAriaText: string;

packages/react-components/review/stable/react-components.api.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1288,7 +1288,6 @@ export interface MessageThreadStrings {
12881288
editedTag: string;
12891289
editMessage: string;
12901290
failToSendTag?: string;
1291-
fileCardGroupMessage: string;
12921291
friday: string;
12931292
liveAuthorIntro: string;
12941293
messageContentAriaText: string;

packages/react-components/src/components/FileDownloadCards.tsx

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import { Icon, IconButton, Spinner, SpinnerSize, TooltipHost } from '@fluentui/react';
55
import React, { useCallback, useState } from 'react';
66
import { useMemo } from 'react';
7+
/* @conditional-compile-remove(file-sharing) */
78
import { useLocale } from '../localization';
89
import { _FileCard } from './FileCard';
910
import { _FileCardGroup } from './FileCardGroup';
@@ -209,6 +210,7 @@ export const _FileDownloadCards = (props: _FileDownloadCardsProps): JSX.Element
209210
return true;
210211
}, []);
211212

213+
/* @conditional-compile-remove(file-sharing) */
212214
const fileCardGroupDescription = useMemo(
213215
() => () => {
214216
const fileGroupLocaleString = props.strings?.fileCardGroupMessage ?? localeStrings.fileCardGroupMessage;
@@ -250,7 +252,7 @@ export const _FileDownloadCards = (props: _FileDownloadCardsProps): JSX.Element
250252

251253
return (
252254
<div style={fileDownloadCardsStyle} data-ui-id="file-download-card-group">
253-
<_FileCardGroup ariaLabel={fileCardGroupDescription()}>
255+
<_FileCardGroup /* @conditional-compile-remove(file-sharing) */ ariaLabel={fileCardGroupDescription()}>
254256
{fileMetadata &&
255257
fileMetadata
256258
.filter((attachment) => {
@@ -294,7 +296,7 @@ const DownloadIconTrampoline = (): JSX.Element => {
294296
};
295297

296298
const useLocaleStringsTrampoline = (): _FileDownloadCardsStrings => {
297-
// @conditional-compile-remove(file-sharing)
299+
/* @conditional-compile-remove(file-sharing) */
298300
return useLocale().strings.messageThread;
299-
return { downloadFile: '', fileCardGroupMessage: useLocale().strings.messageThread.fileCardGroupMessage };
301+
return { downloadFile: '', fileCardGroupMessage: '' };
300302
};

packages/react-components/src/components/MessageThread.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -220,6 +220,7 @@ export interface MessageThreadStrings {
220220
/* @conditional-compile-remove(data-loss-prevention) */
221221
/** String for policy violation message removal details link */
222222
blockedWarningLinkText: string;
223+
/* @conditional-compile-remove(file-sharing) */
223224
/** String for aria text in file attachment group*/
224225
fileCardGroupMessage: string;
225226
}

0 commit comments

Comments
 (0)