Skip to content

Commit 7c68775

Browse files
[OCE] calling sdk 1.36.1 (#5909)
* update stable version * add new callclient dispose api to stable * remove Object.define
1 parent 56eec6f commit 7c68775

17 files changed

Lines changed: 65 additions & 61 deletions

File tree

common/config/rush/variants/stable/common-versions.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
*/
2626
// "some-library": "1.2.3"
2727
// This is the version for stable build (please also update allowedAlternativeVersions below)
28-
"@azure/communication-calling": "^1.35.1",
28+
"@azure/communication-calling": "^1.36.1",
2929
"@azure/communication-common": "2.3.1",
3030
"@azure/communication-chat": "^1.5.4",
3131
"@azure/communication-signaling": "1.0.0-beta.29",
@@ -58,7 +58,7 @@
5858
*/
5959
"allowedAlternativeVersions": {
6060
// This is the version for stable build (please also update preferredVersions above)
61-
"@azure/communication-calling": ["^1.35.1"],
61+
"@azure/communication-calling": ["^1.36.1"],
6262
"@azure/communication-common": ["2.3.1"],
6363
"@azure/communication-chat": ["^1.5.4"],
6464
"@azure/communication-signaling": ["1.0.0-beta.29"],

common/config/rush/variants/stable/pnpm-lock.yaml

Lines changed: 34 additions & 34 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/calling-component-bindings/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,12 +40,12 @@
4040
},
4141
"peerDependencies": {
4242
"@azure/communication-calling-effects": "^1.1.4",
43-
"@azure/communication-calling": "1.36.3-beta.1 || ^1.35.1",
43+
"@azure/communication-calling": "1.36.3-beta.1 || ^1.36.1",
4444
"@types/react": ">=16.8.0 <19.0.0",
4545
"react": ">=16.8.0 <19.0.0"
4646
},
4747
"devDependencies": {
48-
"@azure/communication-calling": "1.36.3-beta.1 || ^1.35.1",
48+
"@azure/communication-calling": "1.36.3-beta.1 || ^1.36.1",
4949
"@azure/communication-calling-effects": "^1.1.4",
5050
"@babel/cli": "^7.27.2",
5151
"@babel/core": "^7.27.4",

packages/calling-stateful-client/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,10 @@
3838
"immer": "10.1.1"
3939
},
4040
"peerDependencies": {
41-
"@azure/communication-calling": "1.36.3-beta.1 || ^1.35.1"
41+
"@azure/communication-calling": "1.36.3-beta.1 || ^1.36.1"
4242
},
4343
"devDependencies": {
44-
"@azure/communication-calling": "1.36.3-beta.1 || ^1.35.1",
44+
"@azure/communication-calling": "1.36.3-beta.1 || ^1.36.1",
4545
"@azure/core-auth": "^1.7.2",
4646
"@babel/cli": "^7.27.2",
4747
"@babel/core": "^7.27.4",

packages/calling-stateful-client/src/CallClientState.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1183,7 +1183,7 @@ export type CallErrorTarget =
11831183
| 'CallAgent.startCall'
11841184
| 'CallClient.createCallAgent'
11851185
| 'CallClient.createTeamsCallAgent'
1186-
| /* @conditional-compile-remove(calling-beta-sdk) */ 'CallClient.dispose'
1186+
| 'CallClient.dispose'
11871187
| 'CallClient.feature'
11881188
| 'CallClient.getDeviceManager'
11891189
| 'CallClient.getEnvironmentInfo'

packages/calling-stateful-client/src/StatefulCallClient.ts

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -173,6 +173,14 @@ export interface StatefulCallClient extends CallClient {
173173
* @public
174174
*/
175175
createTeamsCallAgent(...args: Parameters<CallClient['createTeamsCallAgent']>): Promise<DeclarativeTeamsCallAgent>;
176+
177+
/**
178+
* disposes the CallClient and all its resources.
179+
* - This will also dispose the CallAgent and DeviceManager if they were created.
180+
* @public
181+
* @returns A promise that resolves when the CallClient is disposed.
182+
*/
183+
dispose(): Promise<void>;
176184
}
177185

178186
/**
@@ -280,19 +288,13 @@ class ProxyCallClient implements ProxyHandler<CallClient> {
280288
return Reflect.get(target, prop);
281289
}, 'CallClient.feature');
282290
}
283-
default:
284-
return Reflect.get(target, prop);
285-
}
286-
}
287-
288-
/* @conditional-compile-remove(calling-beta-sdk) */ /* eslint-disable-next-line @typescript-eslint/no-explicit-any */
289-
public set<P extends keyof CallClient>(target: CallClient, prop: P): any {
290-
switch (prop) {
291291
case 'dispose': {
292292
return this._context.withAsyncErrorTeedToState(async () => {
293293
await target.dispose();
294294
}, 'CallClient.dispose');
295295
}
296+
default:
297+
return Reflect.get(target, prop);
296298
}
297299
}
298300
}

packages/communication-react/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@
5656
},
5757
"peerDependencies": {
5858
"@azure/communication-calling-effects": "^1.1.4",
59-
"@azure/communication-calling": "1.36.3-beta.1 || ^1.35.1",
59+
"@azure/communication-calling": "1.36.3-beta.1 || ^1.36.1",
6060
"@azure/communication-chat": "1.6.0-beta.7 || >=1.5.4",
6161
"@types/react": ">=16.8.0 <19.0.0",
6262
"@types/react-dom": ">=16.8.0 <19.0.0",
@@ -111,7 +111,7 @@
111111
"_by-flavor": "rushx _current-flavor && env-cmd -f ../../common/config/env/.env --use-shell"
112112
},
113113
"devDependencies": {
114-
"@azure/communication-calling": "1.36.3-beta.1 || ^1.35.1",
114+
"@azure/communication-calling": "1.36.3-beta.1 || ^1.36.1",
115115
"@azure/communication-calling-effects": "^1.1.4",
116116
"@azure/core-auth": "^1.7.2",
117117
"@babel/cli": "^7.27.2",

0 commit comments

Comments
 (0)