Skip to content

Commit 7d6187c

Browse files
authored
Fix storybook 'Join existing call' preview to account for room Id (#3521)
* Trim locator entered in storybook join existring call preview and validate if it is a roomId * Change files * Duplicate change files for beta release * remove trim
1 parent 880f228 commit 7d6187c

3 files changed

Lines changed: 20 additions & 0 deletions

File tree

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
{
2+
"type": "none",
3+
"area": "fix",
4+
"workstream": "Storybook preview",
5+
"comment": "Validate if locator entered in storybook 'Join Existing Call' preview is a room Id",
6+
"packageName": "@azure/communication-react",
7+
"email": "79475487+mgamis-msft@users.noreply.github.com",
8+
"dependentChangeType": "none"
9+
}
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
{
2+
"type": "none",
3+
"area": "fix",
4+
"workstream": "Storybook preview",
5+
"comment": "Validate if locator entered in storybook 'Join Existing Call' preview is a room Id",
6+
"packageName": "@azure/communication-react",
7+
"email": "79475487+mgamis-msft@users.noreply.github.com",
8+
"dependentChangeType": "none"
9+
}

packages/storybook/stories/CallComposite/snippets/Container.snippet.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,8 @@ const createCallAdapterLocator = (locator: string): CallAdapterLocator | undefin
3333
return { meetingLink: locator };
3434
} else if (isGroupID(locator)) {
3535
return { groupId: locator };
36+
} else if (/^\d+$/.test(locator)) {
37+
return { roomId: locator };
3638
}
3739
return undefined;
3840
};

0 commit comments

Comments
 (0)