Skip to content

Commit 7edfd0e

Browse files
authored
[Accessibility Bug Fix] RTT Modal heading is not defined as heading (#5800)
* update * Change files * update
1 parent d4b8437 commit 7edfd0e

4 files changed

Lines changed: 24 additions & 2 deletions

File tree

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
{
2+
"type": "patch",
3+
"area": "fix",
4+
"workstream": "RTT",
5+
"comment": "Fix bug where modal title is not defined as heading",
6+
"packageName": "@azure/communication-react",
7+
"email": "96077406+carocao-msft@users.noreply.github.com",
8+
"dependentChangeType": "patch"
9+
}
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
{
2+
"type": "patch",
3+
"area": "fix",
4+
"workstream": "RTT",
5+
"comment": "Fix bug where modal title is not defined as heading",
6+
"packageName": "@azure/communication-react",
7+
"email": "96077406+carocao-msft@users.noreply.github.com",
8+
"dependentChangeType": "patch"
9+
}

packages/react-components/src/components/CaptionsSettingsModal.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -348,7 +348,9 @@ export const CaptionsSettingsModal = (props: CaptionsSettingsModalProps): JSX.El
348348
styles={CaptionsSettingsModalStyle}
349349
>
350350
<Stack horizontal horizontalAlign="space-between" verticalAlign="center" className={titleContainerClassName}>
351-
<Text className={titleClassName}>{strings?.captionsSettingsModalTitle}</Text>
351+
<Text className={titleClassName} role="heading" aria-level={1}>
352+
{strings?.captionsSettingsModalTitle}
353+
</Text>
352354
<IconButton
353355
iconProps={{ iconName: 'Cancel' }}
354356
ariaLabel={strings?.captionsSettingsCloseModalButtonAriaLabel}

packages/react-components/src/components/RealTimeTextModal.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,9 @@ export const RealTimeTextModal = (props: RealTimeTextModalProps): JSX.Element =>
9595
styles={RealTimeTextModalStyle}
9696
>
9797
<Stack horizontal horizontalAlign="space-between" verticalAlign="center" className={titleContainerClassName}>
98-
<Text className={titleClassName}>{strings?.realTimeTextModalTitle}</Text>
98+
<Text role="heading" className={titleClassName} aria-level={1}>
99+
{strings?.realTimeTextModalTitle}
100+
</Text>
99101
<IconButton
100102
iconProps={{ iconName: 'Cancel' }}
101103
ariaLabel={strings?.realTimeTextCloseModalButtonAriaLabel}

0 commit comments

Comments
 (0)