Skip to content

Commit 8adcefc

Browse files
[Bugfix] Fix height of control bar so that always has size (#2963)
* fix height of control bar so that always has size * Change files * Duplicate change files for beta release * move where min height is applied
1 parent ed6ab79 commit 8adcefc

4 files changed

Lines changed: 15 additions & 2 deletions

File tree

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "patch",
3+
"comment": "Set min height to control bar to fix issue where control bar contrainer would collapse when side pane buttons are disabled in Composites",
4+
"packageName": "@azure/communication-react",
5+
"email": "94866715+dmceachernmsft@users.noreply.github.com",
6+
"dependentChangeType": "patch"
7+
}
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "patch",
3+
"comment": "Set min height to control bar to fix issue where control bar contrainer would collapse when side pane buttons are disabled in Composites",
4+
"packageName": "@azure/communication-react",
5+
"email": "94866715+dmceachernmsft@users.noreply.github.com",
6+
"dependentChangeType": "patch"
7+
}

packages/react-composites/src/composites/CallComposite/styles/CallControls.styles.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import { IStyle } from '@fluentui/react';
77
export const controlBarContainerStyles: IStyle = {
88
paddingTop: '0.25rem',
99
paddingBottom: '0.25rem',
10-
1110
// @TODO: this should be exposed through a custom CallComposite Theme API that extends the fluent theme with semantic values
1211
boxShadow: `
1312
0px 6.400000095367432px 14.399999618530273px 0px #00000021;

packages/react-composites/src/composites/common/ControlBar/CommonCallControlBar.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ export const CommonCallControlBar = (props: CommonCallControlBarProps & Containe
199199

200200
// only center control bar buttons based on parent container if there are enough space on the screen and not mobile
201201
const controlBarDesktopContainerStyles: IStyle = useMemo(
202-
() => (!props.mobileView && !isOutOfSpace ? { position: 'relative' } : {}),
202+
() => (!props.mobileView && !isOutOfSpace ? { position: 'relative', minHeight: '4.5rem', width: '100%' } : {}),
203203
[props.mobileView, isOutOfSpace]
204204
);
205205

0 commit comments

Comments
 (0)