Skip to content

Commit a33fb42

Browse files
[Bugfix] Microphone lobby fix (#3896)
* Allow mic to be active in the lobby screen * Change files * Duplicate change files for beta release * update logic to be cleaner * Update packages/react-composites CallComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * update comment --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
1 parent f896d25 commit a33fb42

15 files changed

Lines changed: 20 additions & 4 deletions
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
{
2+
"type": "patch",
3+
"area": "fix",
4+
"workstream": "Bug fix",
5+
"comment": "Allow mic to be active in the lobby screen",
6+
"packageName": "@azure/communication-react",
7+
"email": "94866715+dmceachernmsft@users.noreply.github.com",
8+
"dependentChangeType": "patch"
9+
}
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
{
2+
"type": "patch",
3+
"area": "fix",
4+
"workstream": "Bug fix",
5+
"comment": "Allow mic to be active in the lobby screen",
6+
"packageName": "@azure/communication-react",
7+
"email": "94866715+dmceachernmsft@users.noreply.github.com",
8+
"dependentChangeType": "patch"
9+
}

packages/react-composites/src/composites/CallComposite/components/buttons/Microphone.tsx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,11 +38,10 @@ export const Microphone = (props: {
3838
const unmuteMicCapability = adapter.getState().call?.capabilitiesFeature?.capabilities.unmuteMic;
3939

4040
/**
41-
* When call is in Lobby, microphone button should be disabled.
41+
* When call is in connecting state, microphone button should be disabled.
4242
* This is due to to headless limitation where a call can not be muted/unmuted in lobby.
4343
*/
44-
if (_isInLobbyOrConnecting(callStatus)) {
45-
microphoneButtonProps.disabled = true;
44+
if (callStatus === 'Connecting') {
4645
// Lobby page should show the microphone status that was set on the local preview/configuration
4746
// page until the user successfully joins the call.
4847
microphoneButtonProps.checked = isLocalMicrophoneEnabled;
@@ -56,7 +55,6 @@ export const Microphone = (props: {
5655
}
5756
: {};
5857
const styles = useMemo(() => concatButtonBaseStyles(props.styles ?? {}), [props.styles]);
59-
6058
// tab focus on MicrophoneButton on page load
6159
return (
6260
<MicrophoneButton
Loading
Loading
Loading
Loading
Loading
Loading
Loading

0 commit comments

Comments
 (0)