Turn call readiness alwayson (for beta packages only) (#2603)

Author: JamesBurnside

change-beta/@azure-communication-react-35c3e2ae-f269-42cd-a3ee-1560a80b74bc.json

@@ -0,0 +1,7 @@
+{
+  "type": "prerelease",
+  "comment": "turn call readiness alwayson",
+  "packageName": "@azure/communication-react",
+  "email": "2684369+JamesBurnside@users.noreply.github.com",
+  "dependentChangeType": "patch"
+}

change/@azure-communication-react-35c3e2ae-f269-42cd-a3ee-1560a80b74bc.json

@@ -0,0 +1,7 @@
+{
+  "type": "prerelease",
+  "comment": "turn call readiness alwayson",
+  "packageName": "@azure/communication-react",
+  "email": "2684369+JamesBurnside@users.noreply.github.com",
+  "dependentChangeType": "patch"
+}

packages/communication-react/review/beta/communication-react.api.md

@@ -470,7 +470,6 @@ export type CallCompositeOptions = {
     errorBar?: boolean;
     callControls?: boolean | CallControlOptions;
     deviceChecks?: DeviceCheckOptions;
-    callReadinessOptedIn?: boolean;
     onPermissionsTroubleshootingClick?: (permissionsState: {
         camera: PermissionState;
         microphone: PermissionState;
@@ -963,7 +962,6 @@ export type CallWithChatCompositeOptions = {
     }) => void;
     onNetworkingTroubleShootingClick?: () => void;
     onEnvironmentInfoTroubleshootingClick?: () => void;
-    callReadinessOptedIn?: boolean;
 };
 
 // @public

packages/react-composites/review/beta/react-composites.api.md

@@ -321,7 +321,6 @@ export type CallCompositeOptions = {
     errorBar?: boolean;
     callControls?: boolean | CallControlOptions;
     deviceChecks?: DeviceCheckOptions;
-    callReadinessOptedIn?: boolean;
     onPermissionsTroubleshootingClick?: (permissionsState: {
         camera: PermissionState;
         microphone: PermissionState;
@@ -721,7 +720,6 @@ export type CallWithChatCompositeOptions = {
     }) => void;
     onNetworkingTroubleShootingClick?: () => void;
     onEnvironmentInfoTroubleshootingClick?: () => void;
-    callReadinessOptedIn?: boolean;
 };
 
 // @public

packages/react-composites/src/composites/CallComposite/CallComposite.test.tsx

@@ -77,7 +77,7 @@ describe('CallComposite device permission test for different roles', () => {
   });
 });
 
-describe('CallComposite device permission test for call readiness opted in/opted out', () => {
+describe('CallComposite device permission test for call readiness', () => {
   let audioDevicePermissionRequests = 0;
   let videoDevicePermissionRequests = 0;
 
@@ -109,11 +109,4 @@ describe('CallComposite device permission test for call readiness opted in/opted
     expect(audioDevicePermissionRequests).toBe(1);
     expect(videoDevicePermissionRequests).toBe(1);
   });
-
-  /* @conditional-compile-remove(call-readiness) */
-  test('Audio and video device permission should still be requested when callreadiness option opted in', async () => {
-    mount(<CallComposite adapter={adapter} options={{ callReadinessOptedIn: true }} />);
-    expect(audioDevicePermissionRequests).toBe(1);
-    expect(videoDevicePermissionRequests).toBe(1);
-  });
 });

packages/react-composites/src/composites/CallComposite/CallComposite.tsx

@@ -113,12 +113,6 @@ export type CallCompositeOptions = {
    */
   deviceChecks?: DeviceCheckOptions;
   /* @conditional-compile-remove(call-readiness) */
-  /**
-   * Opt in call readiness feature for your call
-   * Setting this to `true` will add call readiness features to the call experience
-   */
-  callReadinessOptedIn?: boolean;
-  /* @conditional-compile-remove(call-readiness) */
   /**
    * Callback you may provide to supply users with further steps to troubleshoot why they have been
    * unable to grant your site the required permissions for the call.
@@ -228,8 +222,6 @@ const MainScreen = (props: MainScreenProps): JSX.Element => {
           onPermissionsTroubleshootingClick={props.options?.onPermissionsTroubleshootingClick}
           /* @conditional-compile-remove(call-readiness) */
           onNetworkingTroubleShootingClick={props.options?.onNetworkingTroubleShootingClick}
-          /* @conditional-compile-remove(call-readiness) */
-          callReadinessOptedIn={props.options?.callReadinessOptedIn}
         />
       );
       break;

packages/react-composites/src/composites/CallComposite/components/ConfigurationPageCameraDropdown.tsx

@@ -22,7 +22,6 @@ export interface ConfigurationPageCameraDropdownProps {
   cameraPermissionGranted: boolean;
   /* @conditional-compile-remove(call-readiness) */
   dropdownProps: Partial<_DevicePermissionDropdownProps>;
-  callReadinessOptedIn?: boolean;
   onClickEnableDevicePermission?: () => void;
 }
 
@@ -53,9 +52,7 @@ export const ConfigurationPageCameraDropdown = (props: ConfigurationPageCameraDr
   );
 
   /* @conditional-compile-remove(call-readiness) */
-  if (props.callReadinessOptedIn) {
-    return <>{props.cameraPermissionGranted ? props.cameraGrantedDropdown : cameraBlockedDropdown}</>;
-  }
+  return props.cameraPermissionGranted ? props.cameraGrantedDropdown : cameraBlockedDropdown;
 
   return props.cameraGrantedDropdown;
 };

packages/react-composites/src/composites/CallComposite/components/ConfigurationPageErrorBar.tsx

@@ -31,7 +31,6 @@ export interface ConfigurationPageErrorBarProps {
     camera: PermissionState;
     microphone: PermissionState;
   };
-  callReadinessOptedIn?: boolean;
 }
 
 /**
@@ -47,9 +46,7 @@ export const ConfigurationPageErrorBar = (props: ConfigurationPageErrorBarProps)
     /* @conditional-compile-remove(call-readiness) */
     onNetworkingTroubleShootingClick,
     /* @conditional-compile-remove(call-readiness) */
-    permissionsState,
-    /* @conditional-compile-remove(call-readiness) */
-    callReadinessOptedIn = false
+    permissionsState
   } = props;
 
   /* @conditional-compile-remove(call-readiness) */
@@ -60,7 +57,7 @@ export const ConfigurationPageErrorBar = (props: ConfigurationPageErrorBarProps)
   };
 
   /* @conditional-compile-remove(call-readiness) */
-  if (showTroubleShootingErrorBar && callReadinessOptedIn) {
+  if (showTroubleShootingErrorBar) {
     return (
       <_TroubleshootingGuideErrorBar
         troubleshootingGuideStrings={permissionTroubleshootingGuideStrings}

packages/react-composites/src/composites/CallComposite/components/ConfigurationPageMicDropdown.tsx

@@ -22,7 +22,6 @@ export interface ConfigurationPageMicDropdownProps {
   micPermissionGranted: boolean;
   /* @conditional-compile-remove(call-readiness) */
   dropdownProps: Partial<_DevicePermissionDropdownProps>;
-  callReadinessOptedIn?: boolean;
   onClickEnableDevicePermission?: () => void;
 }
 
@@ -51,8 +50,7 @@ export const ConfigurationPageMicDropdown = (props: ConfigurationPageMicDropdown
   );
 
   /* @conditional-compile-remove(call-readiness) */
-  if (props.callReadinessOptedIn) {
-    return <> {props.micPermissionGranted ? props.micGrantedDropdown : microphoneBlockedDropdown}</>;
-  }
+  return props.micPermissionGranted ? props.micGrantedDropdown : microphoneBlockedDropdown;
+
   return props.micGrantedDropdown;
 };

packages/react-composites/src/composites/CallComposite/components/LocalDeviceSettings.tsx

@@ -86,7 +86,6 @@ export interface LocalDeviceSettingsType {
   onSelectCamera: (device: VideoDeviceInfo, options?: VideoStreamOptions) => Promise<void>;
   onSelectMicrophone: (device: AudioDeviceInfo) => Promise<void>;
   onSelectSpeaker: (device: AudioDeviceInfo) => Promise<void>;
-  callReadinessOptedIn?: boolean;
   /* @conditional-compile-remove(call-readiness) */
   onClickEnableDevicePermission?: () => void;
 }
@@ -218,8 +217,6 @@ export const LocalDeviceSettings = (props: LocalDeviceSettingsType): JSX.Element
             /* @conditional-compile-remove(call-readiness) */
             dropdownProps={dropdownProps}
             /* @conditional-compile-remove(call-readiness) */
-            callReadinessOptedIn={props.callReadinessOptedIn ?? false}
-            /* @conditional-compile-remove(call-readiness) */
             onClickEnableDevicePermission={props.onClickEnableDevicePermission}
           />
         </Stack>
@@ -239,8 +236,6 @@ export const LocalDeviceSettings = (props: LocalDeviceSettingsType): JSX.Element
             /* @conditional-compile-remove(call-readiness) */
             dropdownProps={dropdownProps}
             /* @conditional-compile-remove(call-readiness) */
-            callReadinessOptedIn={props.callReadinessOptedIn ?? false}
-            /* @conditional-compile-remove(call-readiness) */
             onClickEnableDevicePermission={props.onClickEnableDevicePermission}
           />
           <Dropdown