Skip to content

Commit ac3e86f

Browse files
Fix vscode not showing live linting errors (#5958)
1 parent d14043c commit ac3e86f

4 files changed

Lines changed: 39 additions & 6 deletions

File tree

.vscode/settings.json

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,10 @@
33
"before-after-diff-checker.compileCommand": "rushx _by-flavor \"rushx preprocess\" && (npx eslint $PROCESSED_FILE --fix || true)",
44
"before-after-diff-checker.srcPath": "src",
55
"before-after-diff-checker.enableOnSave": false,
6+
"eslint.workingDirectories": [
7+
{
8+
"mode": "auto"
9+
}
10+
],
611
"typescript.tsdk": "common/config/node_modules/typescript/lib"
712
}

common/config/package.json

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,16 +17,24 @@
1717
},
1818
"devDependencies": {
1919
"@actions/core": "^1.10.1",
20+
"@eslint/js": "~9.28.0",
2021
"@octokit/rest": "~21.1.1",
2122
"@playwright/test": "~1.52.0",
2223
"@rollup/plugin-commonjs": "~25.0.7",
2324
"@rollup/plugin-json": "^6.0.1",
2425
"@types/node": "^22.15.18",
26+
"@typescript-eslint/parser": "^8.34.0",
2527
"beachball": "^2.44.0",
26-
"rollup": "^4.40.2",
28+
"eslint-config-prettier": "^10.1.5",
29+
"eslint-plugin-headers": "~1.3.3",
30+
"eslint-plugin-jsdoc": "^50.6.17",
31+
"eslint": "^9.28.0",
32+
"globals": "~16.2.0",
2733
"rollup-plugin-sourcemaps": "~0.6.3",
2834
"rollup-plugin-svg": "~2.0.0",
35+
"rollup": "^4.40.2",
2936
"ts-node": "^10.9.2",
30-
"typescript": "5.4.5"
37+
"typescript": "5.4.5",
38+
"typescript-eslint": "~8.33.0"
3139
}
3240
}

common/config/rush/pnpm-lock.yaml

Lines changed: 13 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

common/config/rush/variants/stable/pnpm-lock.yaml

Lines changed: 11 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)