Skip to content

Commit af5a516

Browse files
Fix flakey import error when trying to import from fs package (#2928)
1 parent 4f7c22b commit af5a516

4 files changed

Lines changed: 19 additions & 2 deletions

File tree

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "none",
3+
"comment": "Fix flakey import error when trying to import from fs package",
4+
"packageName": "@azure/communication-react",
5+
"email": "2684369+JamesBurnside@users.noreply.github.com",
6+
"dependentChangeType": "none"
7+
}
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "none",
3+
"comment": "Fix flakey import error when trying to import from fs package",
4+
"packageName": "@azure/communication-react",
5+
"email": "2684369+JamesBurnside@users.noreply.github.com",
6+
"dependentChangeType": "none"
7+
}

packages/acs-ui-common/src/conditional-compilation-sample/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ interface B {
6868
* Conditionally import from a package.
6969
*/
7070
/* @conditional-compile-remove(demo) */
71-
import { Dir } from 'fs';
71+
import { DummyImport } from './utils';
7272

7373
/**
7474
* Conditionally export from a module.
@@ -80,7 +80,7 @@ export interface C {
8080
}
8181

8282
/* @conditional-compile-remove(demo) */
83-
export type MyDir = Dir;
83+
export type DummyImportUsage = DummyImport;
8484

8585
/**
8686
* Conditionally add fields to an interface

packages/acs-ui-common/src/conditional-compilation-sample/utils.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,9 @@ import React from 'react';
99
* No conditional compilation examples in this file.
1010
*/
1111

12+
/** @private */
13+
export type DummyImport = unknown;
14+
1215
/** @private */
1316
export type DummyState = unknown;
1417

0 commit comments

Comments
 (0)