Skip to content

Commit bf09ec2

Browse files
[bugfix] Custom data model onFetchAvatarPersonaData fix in PeoplePane for stable (#4391)
* remove unused cc code causing avatarpersona to not update in stable
1 parent 735fb0e commit bf09ec2

4 files changed

Lines changed: 18 additions & 3 deletions

File tree

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
{
2+
"type": "patch",
3+
"area": "fix",
4+
"workstream": "Custom Data Model",
5+
"comment": "Pass down onFetchAvatarPersonaData to peoplepane to display custom data model",
6+
"packageName": "@azure/communication-react",
7+
"email": "edwardlee@microsoft.com",
8+
"dependentChangeType": "patch"
9+
}
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
{
2+
"type": "patch",
3+
"area": "fix",
4+
"workstream": "Custom Data Model",
5+
"comment": "Pass down onFetchAvatarPersonaData to peoplepane to display custom data model",
6+
"packageName": "@azure/communication-react",
7+
"email": "edwardlee@microsoft.com",
8+
"dependentChangeType": "patch"
9+
}

packages/react-composites/src/composites/CallComposite/components/CallArrangement.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,6 @@ export const CallArrangement = (props: CallArrangementProps): JSX.Element => {
158158
updateSidePaneRenderer,
159159
setDrawerMenuItems,
160160
inviteLink: props.callControlProps.callInvitationURL,
161-
/* @conditional-compile-remove(one-to-n-calling) @conditional-compile-remove(PSTN-calls) */
162161
onFetchAvatarPersonaData: props.onFetchAvatarPersonaData,
163162
onFetchParticipantMenuItems: props.callControlProps?.onFetchParticipantMenuItems,
164163
mobileView: props.mobileView,
@@ -168,7 +167,6 @@ export const CallArrangement = (props: CallArrangementProps): JSX.Element => {
168167
updateSidePaneRenderer,
169168
props.callControlProps.callInvitationURL,
170169
props.callControlProps?.onFetchParticipantMenuItems,
171-
/* @conditional-compile-remove(one-to-n-calling) @conditional-compile-remove(PSTN-calls) */
172170
props.onFetchAvatarPersonaData,
173171
props.mobileView,
174172
peopleButtonRef

packages/react-composites/src/composites/CallComposite/pages/CallPage.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,6 @@ export const CallPage = (props: CallPageProps): JSX.Element => {
162162
options: callControlOptions,
163163
increaseFlyoutItemSize: mobileView
164164
}}
165-
/* @conditional-compile-remove(one-to-n-calling) */ /* @conditional-compile-remove(close-captions) */
166165
onFetchAvatarPersonaData={onFetchAvatarPersonaData}
167166
mobileView={mobileView}
168167
modalLayerHostId={props.modalLayerHostId}

0 commit comments

Comments
 (0)