Skip to content

Commit f0ce5c8

Browse files
alkwa-msftgithub-actions[bot]
authored and
carocao-msft
committed
default render of participant list item will yield none for presence (#3619)
* default render of participant list item will yield none for presence * Change files * Duplicate change files for beta release * Change files * Duplicate change files for beta release * Update packages/react-composites CallWithChatComposite browser test snapshots * Update packages/react-composites CallWithChatComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
1 parent 59c0823 commit f0ce5c8

85 files changed

Lines changed: 37 additions & 5 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎change-beta/@azure-communication-react-0861c223-c0be-440a-9864-6c703ec398d8.json‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
{
2+
"type": "patch",
3+
"area": "fix",
4+
"workstream": "fixing bug that was showing an incorrect presence",
5+
"comment": "default render of participant list item will yield none for presence",
6+
"packageName": "@azure/communication-react",
7+
"email": "79329532+alkwa-msft@users.noreply.github.com",
8+
"dependentChangeType": "patch"
9+
}

‎change-beta/@azure-communication-react-7d262c1e-3f9e-4373-9c52-e9d05e4869bd.json‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
{
2+
"type": "patch",
3+
"area": "fix",
4+
"workstream": "default presence should be none",
5+
"comment": "default render of participant list item will yield none for presence",
6+
"packageName": "@azure/communication-react",
7+
"email": "79329532+alkwa-msft@users.noreply.github.com",
8+
"dependentChangeType": "patch"
9+
}

‎change/@azure-communication-react-0861c223-c0be-440a-9864-6c703ec398d8.json‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
{
2+
"type": "patch",
3+
"area": "fix",
4+
"workstream": "fixing bug that was showing an incorrect presence",
5+
"comment": "default render of participant list item will yield none for presence",
6+
"packageName": "@azure/communication-react",
7+
"email": "79329532+alkwa-msft@users.noreply.github.com",
8+
"dependentChangeType": "patch"
9+
}

‎change/@azure-communication-react-7d262c1e-3f9e-4373-9c52-e9d05e4869bd.json‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
{
2+
"type": "patch",
3+
"area": "fix",
4+
"workstream": "default presence should be none",
5+
"comment": "default render of participant list item will yield none for presence",
6+
"packageName": "@azure/communication-react",
7+
"email": "79329532+alkwa-msft@users.noreply.github.com",
8+
"dependentChangeType": "patch"
9+
}

‎packages/react-components/src/components/ParticipantList.tsx‎

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -130,11 +130,7 @@ const onRenderParticipantDefault = (
130130

131131
let presence: PersonaPresence | undefined = undefined;
132132
if (callingParticipant) {
133-
if (callingParticipant.state === 'Connected') {
134-
presence = PersonaPresence.online;
135-
} else if (callingParticipant.state === 'Idle') {
136-
presence = PersonaPresence.away;
137-
}
133+
presence = PersonaPresence.none;
138134
}
139135

140136
const menuItems = createParticipantMenuItems && createParticipantMenuItems(participant);

‎packages/react-composites/tests/browser/snapshots/beta/tests/browser/call/hermetic/CallControls.test.ts-snapshots/call-control-new-experience-people-button-Desktop-Chrome-linux.png‎

-280 Bytes

‎packages/react-composites/tests/browser/snapshots/beta/tests/browser/call/hermetic/CallControls.test.ts-snapshots/call-control-new-experience-people-button-Mobile-Android-Landscape-linux.png‎

-513 Bytes

‎packages/react-composites/tests/browser/snapshots/beta/tests/browser/call/hermetic/CallControls.test.ts-snapshots/call-control-new-experience-people-button-Mobile-Android-Portrait-linux.png‎

-822 Bytes

‎packages/react-composites/tests/browser/snapshots/beta/tests/browser/call/hermetic/ParticipantPane.test.ts-snapshots/ACS-group-call-screen-with-no-add-people-button-Desktop-Chrome-linux.png‎

-217 Bytes

‎packages/react-composites/tests/browser/snapshots/beta/tests/browser/call/hermetic/ParticipantPane.test.ts-snapshots/ACS-group-call-screen-with-no-add-people-button-Mobile-Android-Landscape-linux.png‎

-340 Bytes

0 commit comments

Comments
 (0)
⚡