Skip to content

Commit fac1ceb

Browse files
Update captions banner width and height to increase readability (#3359)
* captions size change * Change files * Duplicate change files for beta release * Update packages/react-composites CallWithChatComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * fix lint * fix storybook * fix storybook * change name; --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
1 parent 01f7906 commit fac1ceb

24 files changed

Lines changed: 31 additions & 11 deletions
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "prerelease",
3+
"comment": "Update captions banner width and height for better readibility",
4+
"packageName": "@azure/communication-react",
5+
"email": "carolinecao@microsoft.com",
6+
"dependentChangeType": "patch"
7+
}
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "prerelease",
3+
"comment": "Update captions banner width and height for better readibility",
4+
"packageName": "@azure/communication-react",
5+
"email": "carolinecao@microsoft.com",
6+
"dependentChangeType": "patch"
7+
}

packages/react-components/src/components/CaptionsBanner.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@ import { Ref } from '@internal/northstar-wrapper';
77
import { _Caption } from './Caption';
88
import {
99
captionContainerClassName,
10-
captionsBannerClassName,
10+
captionsBannerStyles,
1111
captionsContainerClassName,
12-
loadingBannerClassName
12+
loadingBannerStyles
1313
} from './styles/Captions.style';
1414
import { OnRenderAvatarCallback } from '../types';
1515

@@ -102,7 +102,7 @@ export const _CaptionsBanner = (props: _CaptionsBannerProps): JSX.Element => {
102102
<FocusZone as="ul" className={captionsContainerClassName}>
103103
{isCaptionsOn && (
104104
<Ref innerRef={captionsScrollDivRef}>
105-
<Stack verticalAlign="start" styles={captionsBannerClassName(formFactor)}>
105+
<Stack verticalAlign="start" styles={captionsBannerStyles(formFactor)}>
106106
{captions.map((caption) => {
107107
return (
108108
<div key={caption.id} className={captionContainerClassName} data-is-focusable={true}>
@@ -114,7 +114,7 @@ export const _CaptionsBanner = (props: _CaptionsBannerProps): JSX.Element => {
114114
</Ref>
115115
)}
116116
{!isCaptionsOn && (
117-
<Stack verticalAlign="center" className={loadingBannerClassName} data-is-focusable={true}>
117+
<Stack verticalAlign="center" styles={loadingBannerStyles(formFactor)} data-is-focusable={true}>
118118
<Spinner label={strings?.captionsBannerSpinnerText} ariaLive="assertive" labelPosition="right" />
119119
</Stack>
120120
)}

packages/react-components/src/components/styles/Captions.style.ts

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -51,11 +51,11 @@ export const captionContainerClassName = mergeStyles({
5151
/**
5252
* @private
5353
*/
54-
export const captionsBannerClassName = (formFactor: 'default' | 'compact'): IStackStyles => {
54+
export const captionsBannerStyles = (formFactor: 'default' | 'compact'): IStackStyles => {
5555
return {
5656
root: {
5757
overflowX: 'hidden',
58-
height: formFactor === 'compact' ? '4.5rem' : '6.25rem',
58+
height: formFactor === 'compact' ? '4.5rem' : '8.75rem',
5959
overflowY: 'auto',
6060
...scrollbarStyles
6161
}
@@ -65,9 +65,13 @@ export const captionsBannerClassName = (formFactor: 'default' | 'compact'): ISta
6565
/**
6666
* @private
6767
*/
68-
export const loadingBannerClassName = mergeStyles({
69-
height: _pxToRem(100)
70-
});
68+
export const loadingBannerStyles = (formFactor: 'default' | 'compact'): IStackStyles => {
69+
return {
70+
root: {
71+
height: formFactor === 'compact' ? '4.5rem' : '8.75rem'
72+
}
73+
};
74+
};
7175

7276
/**
7377
* @private

packages/react-composites/src/composites/common/CaptionsBanner.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,9 @@ export const CaptionsBanner = (props: { isMobile: boolean }): JSX.Element => {
7575
{
7676
/* @conditional-compile-remove(close-captions) */ <div className={containerClassName}>
7777
<Stack horizontalAlign="center">
78-
<Stack.Item style={{ width: props.isMobile ? mobileViewBannerWidth : desktopViewBannerWidth }}>
78+
<Stack.Item
79+
style={{ width: props.isMobile ? mobileViewBannerWidth : desktopViewBannerWidth, maxWidth: '35rem' }}
80+
>
7981
<_CaptionsBanner
8082
{...captionsBannerProps}
8183
{...handlers}
Loading
Loading
Loading
Loading
Loading

0 commit comments

Comments
 (0)