[bugfix][a11y] video effects item add default aria labels (#3477)

edwardlee-msft · web-flow · commit ff606af5c7c9 · 2023-08-18T10:51:01.000-07:00
* Add default aria label for video effect items
diff --git a/change-beta/@azure-communication-react-c4b8a6bc-ae7d-4fc7-bc19-5a2da34d13c4.json b/change-beta/@azure-communication-react-c4b8a6bc-ae7d-4fc7-bc19-5a2da34d13c4.json
@@ -0,0 +1,9 @@
+{
+  "type": "patch",
+  "area": "fix",
+  "workstream": "video-background-effects",
+  "comment": "Add default aria label for video effect items",
+  "packageName": "@azure/communication-react",
+  "email": "edwardlee@microsoft.com",
+  "dependentChangeType": "patch"
+}
diff --git a/change/@azure-communication-react-c4b8a6bc-ae7d-4fc7-bc19-5a2da34d13c4.json b/change/@azure-communication-react-c4b8a6bc-ae7d-4fc7-bc19-5a2da34d13c4.json
@@ -0,0 +1,9 @@
+{
+  "type": "patch",
+  "area": "fix",
+  "workstream": "video-background-effects",
+  "comment": "Add default aria label for video effect items",
+  "packageName": "@azure/communication-react",
+  "email": "edwardlee@microsoft.com",
+  "dependentChangeType": "patch"
+}
diff --git a/packages/react-components/src/components/VideoEffects/VideoEffectsItem.tsx b/packages/react-components/src/components/VideoEffects/VideoEffectsItem.tsx
@@ -149,7 +149,7 @@ export const _VideoEffectsItem = (props: _VideoEffectsItemProps): JSX.Element =>
               }
         }
         tabIndex={props.disabled ? -1 : 0}
-        aria-label={props.ariaLabel}
+        aria-label={props.ariaLabel ?? props.itemKey}
         aria-disabled={props.disabled}
         role="button"
       >

Original file line number	Diff line number	Diff line change
`@@ -149,7 +149,7 @@ export const _VideoEffectsItem = (props: _VideoEffectsItemProps): JSX.Element =>`
`149`	`149`	`}`
`150`	`150`	`}`
`151`	`151`	`tabIndex={props.disabled ? -1 : 0}`
`152`		`- aria-label={props.ariaLabel}`
	`152`	`+ aria-label={props.ariaLabel ?? props.itemKey}`
`153`	`153`	`aria-disabled={props.disabled}`
`154`	`154`	`role="button"`
`155`	`155`	`>`