Skip to content

Commit ce6a9ff

Browse files
authored
upgrade nodejs from 20 to 24 and update dependencies (#578)
* upgrade nodejs from 20 to 24 and update dependencies * update installation step of ps * update az account count check * upgrade actions/checkout and actions/setup-node from 4 to 6 * remove empty lines
1 parent bbcc074 commit ce6a9ff

File tree

11 files changed

+127
-217
lines changed

11 files changed

+127
-217
lines changed

.github/CODEOWNERS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
@kaverma @kanika1894 @BALAGA-GAYATRI @pulkitaggarwl
1+
@YanaXu

.github/workflows/azure-login-canary.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ jobs:
3030
az --version
3131
3232
- name: Check out repository
33-
uses: actions/checkout@v4
33+
uses: actions/checkout@v6
3434

3535
- name: 'Az CLI login with subscription'
3636
uses: azure/login@v1
@@ -89,4 +89,3 @@ jobs:
8989
- name: Post to slack
9090
shell: bash
9191
run: curl -X POST -H 'Content-type:application/json' --data '{"blocks":[{"type":"section","text":{"type":"mrkdwn","text":"${{steps.slack_report.outputs.report}}"}}]}' https://hooks.slack.com/services/${{SECRETS.SLACK_CHANNEL_SECRET}}
92-

.github/workflows/azure-login-negative.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,12 @@ jobs:
1919
steps:
2020

2121
- name: 'Checking out repo code'
22-
uses: actions/checkout@v4
22+
uses: actions/checkout@v6
2323

24-
- name: Set Node.js 20.x for GitHub Action
25-
uses: actions/setup-node@v4
24+
- name: Set Node.js 24.x for GitHub Action
25+
uses: actions/setup-node@v6
2626
with:
27-
node-version: 20.x
27+
node-version: 24.x
2828

2929
- name: 'Validate build'
3030
run: |
@@ -82,12 +82,12 @@ jobs:
8282

8383
steps:
8484
- name: 'Checking out repo code'
85-
uses: actions/checkout@v4
85+
uses: actions/checkout@v6
8686

87-
- name: Set Node.js 20.x for GitHub Action
88-
uses: actions/setup-node@v4
87+
- name: Set Node.js 24.x for GitHub Action
88+
uses: actions/setup-node@v6
8989
with:
90-
node-version: 20.x
90+
node-version: 24.x
9191

9292
- name: 'Validate build'
9393
run: |

.github/workflows/azure-login-positive.yml

Lines changed: 19 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,12 @@ jobs:
1818

1919
steps:
2020
- name: 'Checking out repo code'
21-
uses: actions/checkout@v4
21+
uses: actions/checkout@v6
2222

23-
- name: Set Node.js 20.x for GitHub Action
24-
uses: actions/setup-node@v4
23+
- name: Set Node.js 24.x for GitHub Action
24+
uses: actions/setup-node@v6
2525
with:
26-
node-version: 20.x
26+
node-version: 24.x
2727

2828
- name: 'Validate build'
2929
run: |
@@ -110,12 +110,12 @@ jobs:
110110

111111
steps:
112112
- name: 'Checking out repo code'
113-
uses: actions/checkout@v4
113+
uses: actions/checkout@v6
114114

115-
- name: Set Node.js 20.x for GitHub Action
116-
uses: actions/setup-node@v4
115+
- name: Set Node.js 24.x for GitHub Action
116+
uses: actions/setup-node@v6
117117
with:
118-
node-version: 20.x
118+
node-version: 24.x
119119

120120
- name: 'Validate build'
121121
run: |
@@ -203,7 +203,7 @@ jobs:
203203
- name: Run Azure Cli
204204
shell: pwsh
205205
run: |
206-
$checkResult = (az account list --output json | ConvertFrom-Json).Count -eq 3
206+
$checkResult = (az account list --output json | ConvertFrom-Json).Count -eq 2
207207
if(-not $checkResult){
208208
throw "Not all checks passed!"
209209
}
@@ -245,12 +245,12 @@ jobs:
245245
environment: Automation test
246246
steps:
247247
- name: 'Checking out repo code'
248-
uses: actions/checkout@v4
248+
uses: actions/checkout@v6
249249

250-
- name: Set Node.js 20.x for GitHub Action
251-
uses: actions/setup-node@v4
250+
- name: Set Node.js 24.x for GitHub Action
251+
uses: actions/setup-node@v6
252252
with:
253-
node-version: 20.x
253+
node-version: 24.x
254254

255255
- name: Install Azure CLI
256256
run: |
@@ -265,11 +265,12 @@ jobs:
265265
- name: Install Powershell
266266
run: |
267267
apt-get update
268-
apt-get install -y wget
269-
wget https://ftp.debian.org/debian/pool/main/i/icu/libicu72_72.1-3_amd64.deb
270-
dpkg -i libicu72_72.1-3_amd64.deb
271-
wget https://github.com/PowerShell/PowerShell/releases/download/v7.5.0/powershell_7.5.0-1.deb_amd64.deb
272-
dpkg -i powershell_7.5.0-1.deb_amd64.deb
268+
apt-get install -y wget apt-transport-https software-properties-common
269+
wget -q "https://packages.microsoft.com/config/ubuntu/24.04/packages-microsoft-prod.deb"
270+
dpkg -i packages-microsoft-prod.deb
271+
rm packages-microsoft-prod.deb
272+
apt-get update
273+
apt-get install -y powershell
273274
274275
- name: Check Powershell Version
275276
shell: pwsh

.github/workflows/azure-login-pr-check.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,16 +10,16 @@ jobs:
1010
runs-on: windows-latest
1111
steps:
1212
- name: Checkout from PR branch
13-
uses: actions/checkout@v4
13+
uses: actions/checkout@v6
1414
with:
1515
repository: ${{ github.event.pull_request.head.repo.full_name }}
1616
ref: ${{ github.event.pull_request.head.ref }}
1717

18-
# Using 20.x version as an example
19-
- name: Set Node.js 20.x for GitHub Action
20-
uses: actions/setup-node@v4
18+
# Using 24.x version as an example
19+
- name: Set Node.js 24.x for GitHub Action
20+
uses: actions/setup-node@v6
2121
with:
22-
node-version: 20.x
22+
node-version: 24.x
2323

2424
- name: installing node_modules
2525
run: npm install

.github/workflows/ci.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,12 @@ jobs:
1818
steps:
1919

2020
- name: 'Checking out repo code'
21-
uses: actions/checkout@v4
21+
uses: actions/checkout@v6
2222

23-
- name: Set Node.js 20.x for GitHub Action
24-
uses: actions/setup-node@v4
23+
- name: Set Node.js 24.x for GitHub Action
24+
uses: actions/setup-node@v6
2525
with:
26-
node-version: 20.x
26+
node-version: 24.x
2727

2828
- name: 'Validate build'
2929
run: |

.github/workflows/codeql.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919

2020
steps:
2121
- name: Checkout repository
22-
uses: actions/checkout@v4
22+
uses: actions/checkout@v6
2323

2424
# Initializes the CodeQL tools for scanning.
2525
- name: Initialize CodeQL

.github/workflows/markdownlint.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,11 @@ jobs:
77
runs-on: ubuntu-latest
88

99
steps:
10-
- uses: actions/checkout@v4
10+
- uses: actions/checkout@v6
1111
- name: Use Node.js
12-
uses: actions/setup-node@v4
12+
uses: actions/setup-node@v6
1313
with:
14-
node-version: 20.x
14+
node-version: 24.x
1515
- name: Run Markdownlint
1616
run: |
1717
npm i -g markdownlint-cli2

action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ branding:
3838
icon: 'login.svg'
3939
color: 'blue'
4040
runs:
41-
using: 'node20'
41+
using: 'node24'
4242
main: 'lib/main/index.js'
4343
post-if: (!env.AZURE_LOGIN_POST_CLEANUP || env.AZURE_LOGIN_POST_CLEANUP != 'false')
4444
post: 'lib/cleanup/index.js'

0 commit comments

Comments
 (0)