Skip to content

Commit 3942602

Browse files
authored
Change to 15% less CPU request for deployment pods in autoscale benchmarking (#1097)
1 parent a9582b4 commit 3942602

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

modules/python/clusterloader2/autoscale/autoscale.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@
1010
from utils.common import str2bool
1111
from utils.logger_config import get_logger, setup_logging
1212

13+
CPU_SCALE_FACTOR = 0.85
14+
1315
setup_logging()
1416
logger = get_logger(__name__)
1517

@@ -218,8 +220,8 @@ def calculate_cpu_request_for_clusterloader2(
218220
# Calculate the cpu request for each pod
219221
pods_per_node = pod_count // node_count
220222
cpu_request = cpu_value // pods_per_node
221-
# Consider 5% less CPU request for deployment pods
222-
cpu_request = int(cpu_request * 0.95)
223+
# Consider 15% less CPU request for deployment pods
224+
cpu_request = int(cpu_request * CPU_SCALE_FACTOR)
223225
return cpu_request
224226

225227

modules/python/tests/test_autoscale.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@
1111
override_config_clusterloader2,
1212
execute_clusterloader2,
1313
collect_clusterloader2,
14-
main
14+
main,
15+
CPU_SCALE_FACTOR,
1516
)
1617
from kubernetes.client.models import (
1718
V1Node, V1NodeStatus, V1NodeCondition, V1NodeSpec, V1ObjectMeta, V1Pod, V1PodSpec
@@ -67,8 +68,8 @@ def test_calculate_cpu_request_with_warmup_success(self, mock_cleanup, mock_kube
6768
without_warmup_cpu_request = calculate_cpu_request_for_clusterloader2('{"autoscaler": "true"}', 1, 1, 'false', '/mock/path', 'warmup_deployment.yaml')
6869

6970
# Assert the CPU request calculation
70-
self.assertEqual(with_warmup_cpu_request, 1800*0.95) # 2000m - 100m (allocated) - 100m (warmup)
71-
self.assertEqual(without_warmup_cpu_request, 1900*0.95) # 2000m - 100m (allocated)
71+
self.assertEqual(with_warmup_cpu_request, int(1800 * CPU_SCALE_FACTOR)) # 2000m - 100m (allocated) - 100m (warmup)
72+
self.assertEqual(without_warmup_cpu_request, int(1900 * CPU_SCALE_FACTOR)) # 2000m - 100m (allocated)
7273

7374
# Assert cleanup is called
7475
mock_cleanup.assert_called_once_with('/mock/path', 'warmup_deployment.yaml')

0 commit comments

Comments
 (0)