Coverage (#112)

Author: Beakerboy

src/buildingpart.js

@@ -429,12 +429,9 @@ class BuildingPart {
    * @return {number} degrees
    */
   static atanRadToCompassDeg(rad) {
-    if (rad > 0) {
-      rad = rad - 2 * Math.PI;
-    }
-    return ((rad * -1 + Math.PI / 2) % (2 * Math.PI)) * 360;
+    return ((Math.PI - rad + 3 * Math.PI / 2) % (2 * Math.PI)) * 180 / Math.PI;
   }
-  
+
   /**
    * Get the THREE.material for a given way
    *

src/extras/BuildingShapeUtils.js

@@ -9,7 +9,7 @@ class BuildingShapeUtils extends ShapeUtils {
    * Create the shape of this way.
    *
    * @param {DOM.Element} way - OSM XML way element.
-   * @param {[number, number]} nodelist - list of all nodes
+   * @param {number => number[2]} nodelist - dictionary of all nodes
    *
    * @return {THREE.Shape} shape - the shape
    */
@@ -27,7 +27,7 @@ class BuildingShapeUtils extends ShapeUtils {
     for (const element of elements) {
       ref = element.getAttribute('ref');
       node = nodelist[ref];
-      // Th node requires a differnet function call.
+      // The first node requires a different function call.
       if (first) {
         first = false;
         shape.moveTo(parseFloat(node[0]), parseFloat(node[1]));

test/buildingpart.test.js

@@ -5,3 +5,8 @@ test('Test Cardinal to Degree', () => {
   expect(BuildingPart.cardinalToDegree('sSw')).toBe(202);
   expect(BuildingPart.cardinalToDegree('Wse')).toBeUndefined();
 });
+
+test('radToDeg', () => {
+  expect (BuildingPart.atanRadToCompassDeg(0)).toBe(90);
+  expect (BuildingPart.atanRadToCompassDeg(Math.PI / 2)).toBe(0);
+});

test/utils.test.js

@@ -15,9 +15,23 @@ import { BuildingShapeUtils } from '../src/extras/BuildingShapeUtils.js';
 
 
 /** Test createShape */
-// test('', () => {
-//
-// });
+test('', () => {
+  var way = '<way id="1"><nd ref="1"/><nd ref="2"/><nd ref="3"/><nd ref="1"/></way>';
+  let parser = new window.DOMParser();
+  let xmlData = parser.parseFromString(way, 'text/xml');
+  let nodelist = {
+    1: [1, 1],
+    2: [1, -1],
+    3: [-1, 1],
+  };
+  const shape = BuildingShapeUtils.createShape(xmlData, nodelist);
+  expect(shape.extractPoints().shape.length).toBe(4);
+  const points = shape.extractPoints().shape;
+  expect([points[0].x, points[0].y]).toStrictEqual(nodelist[1]);
+  expect([points[1].x, points[1].y]).toStrictEqual(nodelist[2]);
+  expect([points[2].x, points[2].y]).toStrictEqual(nodelist[3]);
+  expect([points[0].x, points[0].y]).toStrictEqual(nodelist[1]);
+});
 
 /** Test isClosed */
 test('Test Closed Way', () => {