Skip to content

Commit b66d3e0

Browse files
authored
pkg/domain/crossks: fix flaky TestManager coordinator session count check (pingcap#66832)
close pingcap#66831
1 parent 3a75c22 commit b66d3e0

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

pkg/domain/crossks/cross_ks_test.go

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ package crossks_test
1717
import (
1818
"context"
1919
"testing"
20+
"time"
2021

2122
"github.com/pingcap/errors"
2223
"github.com/pingcap/kvproto/pkg/keyspacepb"
@@ -235,9 +236,11 @@ func TestManager(t *testing.T) {
235236
})
236237
require.EqualValues(t, 1, tableIDCount)
237238
require.True(t, coordinator.ContainsInternalSession(se))
238-
require.EqualValues(t, 1, coordinator.InternalSessionCount())
239+
require.GreaterOrEqual(t, coordinator.InternalSessionCount(), 1)
239240
return nil
240241
}))
241-
require.Zero(t, coordinator.InternalSessionCount())
242+
require.Eventually(t, func() bool {
243+
return coordinator.InternalSessionCount() == 0
244+
}, 10*time.Second, 20*time.Millisecond)
242245
})
243246
}

0 commit comments

Comments
 (0)