Skip to content

Commit 4f794ef

Browse files
committed
fix(types): fix incorrect nested type names
There was a name-duplication which led to un-inmplemented types. The good thing is that this was the last issue that kept all 72 APIs from compiling.
1 parent 7e24393 commit 4f794ef

1 file changed

Lines changed: 8 additions & 6 deletions

File tree

src/mako/lib/util.py

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,8 @@ def canonical_type_name(s):
255255
return capitalize(s)
256256

257257
def nested_type_name(sn, pn):
258-
return sn + canonical_type_name(pn)
258+
suffix = canonical_type_name(pn)
259+
return sn + suffix
259260

260261
# Make properties which are reserved keywords usable
261262
def mangle_ident(n):
@@ -633,7 +634,7 @@ def recurse_properties(prefix, rs, s, parent_ids):
633634
rs = s
634635
# end this is already a perfectly valid type
635636

636-
properties = s.get('properties', {rs.id: s})
637+
properties = s.get('properties', {'': s})
637638
for pn, p in properties.iteritems():
638639
link_used(p, rs)
639640
if is_nested_type_property(p):
@@ -645,12 +646,13 @@ def recurse_properties(prefix, rs, s, parent_ids):
645646
if 'items' in p:
646647
ns.update((k, deepcopy(v)) for k, v in p.items.iteritems())
647648

648-
recurse_properties(nested_type_name(prefix, pn), ns, ns, append_unique(parent_ids, rs.id))
649+
recurse_properties(ns.id, ns, ns, append_unique(parent_ids, rs.id))
649650
elif _is_map_prop(p):
650-
recurse_properties(nested_type_name(prefix, pn), rs, p.additionalProperties, append_unique(parent_ids, rs.id))
651+
recurse_properties(nested_type_name(prefix, pn), rs,
652+
p.additionalProperties, append_unique(parent_ids, rs.id))
651653
elif 'items' in p:
652-
# it's an array
653-
recurse_properties(nested_type_name(prefix, pn), rs, p.items, append_unique(parent_ids, rs.id))
654+
recurse_properties(nested_type_name(prefix, pn), rs,
655+
p.items, append_unique(parent_ids, rs.id))
654656
# end handle prop itself
655657
# end for each property
656658
# end utility

0 commit comments

Comments
 (0)