fix: ensure new scoped serviceprovider for every job that is instantiated.

Author: VisualBean

src/ByteBard.GUSTO.Examples/InMemoryJobStorageProvider.cs

@@ -4,7 +4,7 @@
 
 public class InMemoryJobStorageProvider : IJobStorageProvider<JobRecord>
 {
-    private readonly List<JobRecord> _jobs = new();
+    private static readonly List<JobRecord> _jobs = new();
     private readonly object _lock = new();
 
     public Task StoreJobAsync(JobRecord jobStorageRecord, CancellationToken cancellationToken)

src/ByteBard.GUSTO.JobQueue/JobQueueWorker.cs

@@ -140,7 +140,7 @@ private async Task ProcessBatchCycleAsync(ParallelOptions parallelOptions, Cance
             return;
         }
 
-        await ProcessBatchAsync(jobStorageRecords, storage, scope.ServiceProvider, parallelOptions);
+        await ProcessBatchAsync(jobStorageRecords, storage, parallelOptions);
     }
 
     private async Task<IEnumerable<TStorageRecord>> FetchPendingJobsAsync(
@@ -162,7 +162,6 @@ private async Task<IEnumerable<TStorageRecord>> FetchPendingJobsAsync(
     private async Task ProcessBatchAsync(
         List<TStorageRecord> jobStorageRecords,
         IJobStorageProvider<TStorageRecord> storage,
-        IServiceProvider scopedServiceProvider,
         ParallelOptions parallelOptions)
     {
         using var batchActivity = ActivitySource.StartActivity("ProcessBatch");
@@ -173,7 +172,7 @@ private async Task ProcessBatchAsync(
 
         await Parallel.ForEachAsync(jobStorageRecords, parallelOptions, async (storedJob, ct) =>
         {
-            await ExecuteJobAsync(storedJob, storage, scopedServiceProvider, ct);
+            await ExecuteJobAsync(storedJob, storage, ct);
         });
 
         batchStopwatch.Stop();
@@ -184,7 +183,6 @@ await Parallel.ForEachAsync(jobStorageRecords, parallelOptions, async (storedJob
     private async Task ExecuteJobAsync(
         TStorageRecord storedJob,
         IJobStorageProvider<TStorageRecord> storage,
-        IServiceProvider scopedServiceProvider,
         CancellationToken ct)
     {
         using var jobActivity = ActivitySource.StartActivity("ExecuteJob");
@@ -197,7 +195,8 @@ private async Task ExecuteJobAsync(
         {
             var jobType = Type.GetType(storedJob.JobType);
             var arguments = JsonConvert.DeserializeObject<object[]>(storedJob.ArgumentsJson, _settings);
-            var jobInstance = ActivatorUtilities.CreateInstance(scopedServiceProvider, jobType);
+            using var scope = _serviceProvider.CreateScope();
+            var jobInstance = ActivatorUtilities.CreateInstance(scope.ServiceProvider, jobType);
             var method = jobType.GetMethod(storedJob.MethodName);
             await (Task)method.Invoke(jobInstance, arguments);