Skip to content

Commit 87d1d3a

Browse files
committed
Makes missing GIT_PROTOCOL an error
When this is hit, the project is NOT configured and you CANNOT build. Having cmake return 0 is wrong.
1 parent 29394e5 commit 87d1d3a

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

CMakeLists.txt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -123,11 +123,10 @@ endif()
123123
find_package(Git)
124124

125125
if(NOT GIT_PROTOCOL)
126-
message("[INFO] Select Either git:// or http:// for checking out git submodules.
127-
If you are behind a firewall then likely you need to choose http:// instead.")
128126
set(GIT_PROTOCOL "git://" CACHE STRING "Choose protocol to be used by git" FORCE)
129127
set_property(CACHE GIT_PROTOCOL PROPERTY STRINGS "git://" "http://")
130-
return()
128+
message(FATAL_ERROR "[ERROR] Select either git:// or http:// for checking out git submodules.
129+
If you are behind a firewall then likely you need to choose http:// instead.")
131130
endif()
132131

133132
if(GIT_PROTOCOL MATCHES "http://")

0 commit comments

Comments
 (0)