Skip to content

Commit c0aa782

Browse files
committed
Merge pull request #1161 from chaosphere2112/vcs_anim_no_png
VCS2D Animation Speedup all right since everybody is happy and it works for both sam and I. Merging. @williams13 please go ahead and build again
2 parents a8e12d1 + 0a0ff2e commit c0aa782

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

Packages/vcs/Lib/VTKAnimate.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ def run(self):
100100
while not self.is_stopped():
101101
self.wait_if_paused()
102102

103-
self.controller.draw_frame(allow_static = True, render_offscreen = False, main_window_png = True)
103+
self.controller.draw_frame(allow_static = False, render_offscreen = False, main_window_png = False)
104104

105105
self.controller.frame_num += 1
106106
if self.controller.frame_num >= self.controller.number_of_frames():
@@ -258,7 +258,7 @@ def draw_frame(self, frame_num = None, render_offscreen=True, allow_static=True,
258258
else:
259259
self.reclaim_renderers()
260260

261-
update_input(self.vcs_self, self._number_of_dims_used_for_plot, frame_num)
261+
update_input(self.vcs_self, self._number_of_dims_used_for_plot, frame_num, update=False)
262262

263263
self.vcs_self.backend.renWin.Render()
264264

Packages/vcs/Lib/configurator.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -164,6 +164,7 @@ def __init__(self, canvas):
164164
self.save_timer = None
165165
self.save_listener = None
166166
self.save_anim_button = None
167+
self.anim_button = None
167168
self.listeners = []
168169
self.animation_last_frame_time = datetime.datetime.now()
169170
# Map custom templates to their source template
@@ -542,7 +543,7 @@ def setup_animation(self):
542543
if self.initialized == False:
543544
self.canvas.animate.create()
544545
anim_toolbar = self.toolbar.add_toolbar("Animation")
545-
anim_toolbar.add_toggle_button("Animation", on=self.start_animating, off=self.stop_animating, on_prefix="Run", off_prefix="Stop")
546+
self.anim_button = anim_toolbar.add_toggle_button("Animation", on=self.start_animating, off=self.stop_animating, on_prefix="Run", off_prefix="Stop")
546547
anim_toolbar.add_button(["Step Forward"], action=self.step_forward)
547548
anim_toolbar.add_button(["Step Backward"], action=self.step_back)
548549
anim_toolbar.add_slider_button(0, 0, self.canvas.animate.number_of_frames(), "Time Slider", update=self.set_animation_frame, end=self.final_animation_frame)
@@ -558,6 +559,9 @@ def step_back(self, state):
558559

559560
def save_animation_press(self, state):
560561
if state == 1:
562+
if self.animation_timer:
563+
self.stop_animating()
564+
self.anim_button.set_state(0)
561565
self.save_listener = self.interactor.AddObserver("TimerEvent", self.save_tick)
562566
self.save_timer = self.interactor.CreateRepeatingTimer(10)
563567
else:
@@ -624,7 +628,7 @@ def set_animation_speed(self, value):
624628
def animate(self, obj, event):
625629
if self.animation_timer is not None and datetime.datetime.now() - self.animation_last_frame_time > datetime.timedelta(0, 0, 0, int(.9 * 1000. / self.animation_speed)):
626630
self.animation_last_frame_time = datetime.datetime.now()
627-
self.canvas.animate.draw_frame((self.canvas.animate.frame_num + 1) % self.canvas.animate.number_of_frames())
631+
self.canvas.animate.draw_frame((self.canvas.animate.frame_num + 1) % self.canvas.animate.number_of_frames(), render_offscreen=False, allow_static=False)
628632

629633
def start_animating(self):
630634
if self.animation_timer is None:
@@ -634,7 +638,6 @@ def stop_animating(self):
634638
if self.animation_timer is not None:
635639
t, self.animation_timer = self.animation_timer, None
636640
self.interactor.DestroyTimer(t)
637-
self.canvas.animate.draw_frame(allow_static = False, render_offscreen = False)
638641

639642
def set_animation_frame(self, value):
640643
value = int(value)

0 commit comments

Comments
 (0)