Sam,
As long as the ctests pass this should be fine. Thanks.

— Tom

From: Sam Fries <notifications@github.commailto:notifications@github.com>
Reply-To: UV-CDAT/uvcdat <reply@reply.github.commailto:reply@reply.github.com>
Date: Wednesday, April 1, 2015 at 2:40 PM
To: UV-CDAT/uvcdat <uvcdat@noreply.github.commailto:uvcdat@noreply.github.com>
Cc: "Maxwell, Thomas P. (GSFC-606.2)[SCIENCE APPLICATIONS INTL CORP]" <thomas.maxwell@nasa.govmailto:thomas.maxwell@nasa.gov>
Subject: [uvcdat] 3D support for vcs.update (#1184)

@ThomasMaxwellhttps://github.com/ThomasMaxwell I was trying to cook up a camera manipulation demo for @jypeterhttps://github.com/jypeter when I discovered that updating the camera on a 3D graphics method wasn't doing much, even when I replotted / called canvas.update(). I made a few minimal tweaks to better support those operations. If you can take a look at what I did and make sure it wasn't anything dumb, that'd be awesome.

You can view, comment on, or merge this pull request online at:

#1184

Commit Summary

• Made camera updates propagate when replotting a GM in 3d mode
• Merge branch 'master' into gm_update_3d
• Made vcs.update() work on 3D Plots

File Changes

• M Packages/DV3D/Application.pyhttps://github.com/3D support for vcs.update #1184/files#diff-0 (1)
• M Packages/DV3D/PointCloudViewer.pyhttps://github.com/3D support for vcs.update #1184/files#diff-1 (2)
• M Packages/DV3D/StructuredGridPlot.pyhttps://github.com/3D support for vcs.update #1184/files#diff-2 (2)
• M Packages/vcs/Lib/VTKPlots.pyhttps://github.com/3D support for vcs.update #1184/files#diff-3 (22)

Patch Links:

• https://github.com/UV-CDAT/uvcdat/pull/1184.patch
• https://github.com/UV-CDAT/uvcdat/pull/1184.diff

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1184.

Sure.. I will run the test and if all works will merge it.

LGTM 👍

Thanks Sam et al!
I'm still experimenting with DV3D and I have a few issues to submit before I forget about them. I have only completed #1187 so far