Conversation
Contributor
There was a problem hiding this comment.
warning seems un-necessary here. I would just document it. Probably create a --help option on the vcs scripts?
Contributor
Author
There was a problem hiding this comment.
I actually had thankful comments about the "Q" warning so I think we should leave this one in.
Not many people read the documentation, especially people that used vcs before
I'm willing to remove the warning for blank screens.
we can't implement a --help in this case, it's part of the vcs module not a script.
@jypeter I would love to hear what you have to say about this.
Contributor
Author
|
@aashish24 @dlonie please review |
Contributor
|
Looks like @aashish24 already did, or is there a new version/comment I'm missing? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.