setup_runtime.sh needs to be sourced with full path

[doutriaux1]

At least on Linux systems.

sourced: Subscript out of range.
dirname: missing operand
Try `dirname --help' for more information.

I tried dirname --help and got this:
Usage: dirname NAME
   or:  dirname OPTION

[aashish24]

@jbeezley Could you please have a look at this?

[jbeezley]

This is an issue with setup_runtime.csh correct? The method used to get the directory of the script doesn't actually work at all. When sourced, $_ is returning the previous command's argument list despite what several stack exchange answers say. Is there any reason we can't just hard code the install path in here? I don't think the uvcdat install is relocatable anyway.

[doutriaux1]

no this is an issue with .sh not .csh

[doutriaux1]

I argued your point with @aashish24 the hardcoding many times. It used to be hardcoded.

Somehow @aashish24 switch to this way because of cpack on mac. I think it would be preferable to hard code and in the case of cpack simply have another one.

[aashish24]

@jbeezley we cannot easily hard-code the paths. Primarily because the same csh file is used by the DMG installer as well as for the user-chosen location. Also, it could be combination of both of these as well. Also, I believe depending on the version of the Mac, it may put the binary at different location. I said earlier as well, I am not against the hard-coded path as far as it works for all the situations we want to tackle. It may require more work than couple of hours and if that's the case, then we probably have to do it when we get the allocation for it.

[jbeezley]

Are you sure? As far as I know, bash doesn't error out on bad subscripts, it just spits out an empty string. Also, there is no sourced variable in the bash version.

Anyway, I did some more experimenting with $_ in cshell. It does seem to work in tcsh, but you need the shebang line at the beginning. Using a simple test like this:

#!/bin/csh
set sourced=($_)
echo $sourced[2]

I get that same error using cshell, but not tcshell on ubuntu 14.04.

[aashish24]

@doutriaux1 the hard-coding it had, would not have worked even we had not supported the DMG installer. That code had to go away regardless.

[doutriaux1]

I'm still not sure why? If we don't support relocating we don't need relative path

[doutriaux1]

BTW dmg is using the .sh not .csh