Skip to content

Optimize vtk#1038

Merged
chaosphere2112 merged 1 commit intoCDAT:masterfrom
doutriaux1:optimize_vtk
Feb 21, 2015
Merged

Optimize vtk#1038
chaosphere2112 merged 1 commit intoCDAT:masterfrom
doutriaux1:optimize_vtk

Conversation

@doutriaux1
Copy link
Copy Markdown
Contributor

@aashish24 @dlonie @chaosphere2112 @williams13

This is the merge for animations

I still need input to add tests for animations, not sure how to go at it, but just added option to "preserve" png files at exit might be the way to go.

Lots of changes, so it's a big job to review.

Comment thread Packages/vcs/Lib/Canvas.py Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, it's generally a bad idea to mix large whitespace-only (or other maintenance-oriented) changes with actual code changes.

It makes it more difficult for reviewers to find the actual changes that need reviewing, and leads to odd VCS histories (for instance, changing non-VTK related files in a topic that is focused on cleaning up VTK usage).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think these are due to our pre-commit that refuses to have any white space at the end of lines.... VERY annoying, so I believe I ran some sed on the files to get rid of all of them massively

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants