Boxfill bug branch clean up

[doutriaux1]

@potter2 this should help your issues
@chaosphere2112 also help with yours (might need to start a new vt though)

@aashish24 @dlonie @chaosphere2112 care to review?

[aashish24]

@dlonie can you review this branch?

[alliepiper]

building now

[alliepiper]

Fails at cmake:

CMake Error: Error in cmake code at
/ssd/src/uvcdat/testing/vcs/CMakeLists.txt:585:
Parse error.  Function missing ending ")".  End of file reached.
-- Configuring incomplete, errors occurred!
See also "/ssd/src/uvcdat-build/CMakeFiles/CMakeOutput.log".

[doutriaux1]

@dlonie I closed the parenthesis, please try again

[doutriaux1]

@dlonie I forget to mention the baseline : CDAT/uvcdat-testdata#34

[alliepiper]

New test hangs indefinitely:

99: Test command: /ssd/src/uvcdat-build/install/bin/python "/ssd/src/uvcdat/testing/vcs/test_box_custom_as_def_vistrails_exts.py" "/ssd/src/uvcdat-build/uvcdat-testdata/baselines/vcs/test_box_custom_as_def_vistrails_exts.png"
99: Test timeout computed to be: 1500
99: fnm: test_box_custom_as_def_vistrails_exts.png
99: src: /ssd/src/uvcdat-build/uvcdat-testdata/baselines/vcs/test_box_custom_as_def_vistrails_exts.png
99: ERROR: In /ssd/src/uvcdat-build/build/VTK/IO/Image/vtkPNGReader.cxx, line 44
99: vtkPNGReader (0x4dbe0a0): Unable to open file test_box_custom_as_def_vistrails_exts.png.png
99: 
99: ERROR: In /ssd/src/uvcdat-build/build/VTK/Imaging/Core/vtkImageExtractComponents.cxx, line 239
99: vtkImageExtractComponents (0x522b270): Execute: Component 1 is not in input.
99: 
99: Found Baselines:
99: - /ssd/src/uvcdat-build/uvcdat-testdata/baselines/vcs/test_box_custom_as_def_vistrails_exts.png
99: ERROR: In /ssd/src/uvcdat-build/build/VTK/Imaging/Core/vtkImageDifference.cxx, line 397
99: vtkImageDifference (0x52b5e80): ExecuteInformation: Input are not the same size.
99:  Input1 is: 0,0,0,0,0,0
99:  Input2 is: 0,1199,0,1090,0,0
99: 
99: ERROR: In /ssd/src/uvcdat-build/build/VTK/Imaging/Core/vtkImageDifference.cxx, line 221
99: vtkImageDifference (0x52b5e80): Execute: All ScalarTypes must be unsigned char
99: 
99: Comparing 'test_box_custom_as_def_vistrails_exts.png.png' to '/ssd/src/uvcdat-build/uvcdat-testdata/baselines/vcs/test_box_custom_as_def_vistrails_exts.png'...diff=8000.000000, New best!
99: All baselines failed! Lowest error (8000.000000) exceeds threshold (10.000000).
99: Saving image diff at 'test_box_custom_as_def_vistrails_exts.png_diff.png'.
99: Warning: In /ssd/src/uvcdat-build/build/VTK/IO/Image/vtkPNGWriter.cxx, line 215
99: vtkPNGWriter (0x52bc2d0): PNGWriter only supports unsigned char and unsigned short inputs

[chaosphere2112]

I'm having the same issue @dlonie is on my mac.

[chaosphere2112]

This would be the source of the issue, @doutriaux1

[alliepiper]

Tests pass with this diff:

diff --git a/testing/vcs/test_box_custom_as_def_vistrails_exts.py b/testing/vcs/test_box_custom_as_def_vistrails_exts.py
index 6acd67a..552fd7f 100644
--- a/testing/vcs/test_box_custom_as_def_vistrails_exts.py
+++ b/testing/vcs/test_box_custom_as_def_vistrails_exts.py
@@ -25,5 +25,4 @@ src =sys.argv[1]
 x.png(fnm)
 print "fnm:",fnm
 print "src:",src
-ret = checkimage.check_result_image(fnm+'.png',src,checkimage.defaultThreshold)
-raw_input("press enter")
+ret = checkimage.check_result_image(fnm,src,checkimage.defaultThreshold)

[doutriaux1]

@dlonie @chaosphere2112 https://open.cdash.org/buildSummary.php?buildid=3780347

[doutriaux1]

and also: https://open.cdash.org/buildSummary.php?buildid=3780363
😉

[alliepiper]

What's up with the vertical tick labels in that failing test?

https://open.cdash.org/testDetails.php?test=321954010&build=3742825

Is that intended, or a known issue?

It doesn't seem related to the branch (the reference image is screwy as well...), merging.

[doutriaux1]

@dlonie it looks like we're plotting 2 variable with different yaxis on top of each other. I'll take a look it might be worth cleaning up the test anyway.