Skip to content

Fix list method#1287

Merged
doutriaux1 merged 1 commit intoreleasefrom
vcs3D_fix_dv3d_list
May 6, 2015
Merged

Fix list method#1287
doutriaux1 merged 1 commit intoreleasefrom
vcs3D_fix_dv3d_list

Conversation

@ThomasMaxwell
Copy link
Copy Markdown
Contributor

Fixes #1285 .

@ThomasMaxwell ThomasMaxwell added this to the 2.2 milestone May 6, 2015
@doutriaux1
Copy link
Copy Markdown
Contributor

@ThomasMaxwell what about setting the default values to not None? Is that ok they are None?

@ThomasMaxwell
Copy link
Copy Markdown
Contributor Author

They are supposed to be None. Setting then to non-None overrides the default value.

From: Charles Doutriaux <notifications@github.commailto:notifications@github.com>
Reply-To: UV-CDAT/uvcdat <reply@reply.github.commailto:reply@reply.github.com>
Date: Wednesday, May 6, 2015 at 1:36 PM
To: UV-CDAT/uvcdat <uvcdat@noreply.github.commailto:uvcdat@noreply.github.com>
Cc: "Maxwell, Thomas P. (GSFC-606.2)[SCIENCE APPLICATIONS INTL CORP]" <thomas.maxwell@nasa.govmailto:thomas.maxwell@nasa.gov>
Subject: Re: [uvcdat] Fix list method (#1287)

@ThomasMaxwellhttps://github.com/ThomasMaxwell what about setting the default values to not None? Is that ok they are None?


Reply to this email directly or view it on GitHubhttps://github.com//pull/1287#issuecomment-99546317.

@ThomasMaxwell
Copy link
Copy Markdown
Contributor Author

Vcs3D assumes that default values might be computed as a function of the input dataset (e.g. vertical scaling as a function of the number of levels in the dataset), therefore they are not hard coded in the graphics method. Anything specified in the graphics method overrides the default value.

From: , "Maxwell, Thomas P. (GSFC-606.2)[SCIENCE APPLICATIONS INTL CORP]" <thomas.maxwell@nasa.govmailto:thomas.maxwell@nasa.gov>
Date: Wednesday, May 6, 2015 at 2:06 PM
To: UV-CDAT/uvcdat <reply@reply.github.commailto:reply@reply.github.com>
Subject: Re: [uvcdat] Fix list method (#1287)

They are supposed to be None. Setting then to non-None overrides the default value.

From: Charles Doutriaux <notifications@github.commailto:notifications@github.com>
Reply-To: UV-CDAT/uvcdat <reply@reply.github.commailto:reply@reply.github.com>
Date: Wednesday, May 6, 2015 at 1:36 PM
To: UV-CDAT/uvcdat <uvcdat@noreply.github.commailto:uvcdat@noreply.github.com>
Cc: "Maxwell, Thomas P. (GSFC-606.2)[SCIENCE APPLICATIONS INTL CORP]" <thomas.maxwell@nasa.govmailto:thomas.maxwell@nasa.gov>
Subject: Re: [uvcdat] Fix list method (#1287)

@ThomasMaxwellhttps://github.com/ThomasMaxwell what about setting the default values to not None? Is that ok they are None?


Reply to this email directly or view it on GitHubhttps://github.com//pull/1287#issuecomment-99546317.

@doutriaux1
Copy link
Copy Markdown
Contributor

makes sense. thanks.

doutriaux1 added a commit that referenced this pull request May 6, 2015
@doutriaux1 doutriaux1 merged commit 94f63d6 into release May 6, 2015
@doutriaux1 doutriaux1 deleted the vcs3D_fix_dv3d_list branch May 6, 2015 20:59
@aashish24 aashish24 mentioned this pull request May 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants