Fixed the ordering of images for regression testing#1307
Merged
doutriaux1 merged 1 commit intoreleasefrom May 11, 2015
Merged
Conversation
So that the cdash will show them correctly in the right order
Contributor
|
Thanks! |
doutriaux1
added a commit
that referenced
this pull request
May 11, 2015
Fixed the ordering of images for regression testing
Contributor
|
That caused the error to go away completely when it should have just switched the images in cdash. This line makes me very suspicious. I think an |
Contributor
|
what are you saying @jbeezley ? You don't like "magic"? |
Contributor
|
I would say leave it for 2.3 and go over all of the tests to make sure failures are reported correctly (as in #1015). |
Contributor
Author
|
@jbeezley agree with you. it should have ret = (anything but 0). I will push a branch post 2.2 release. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that the cdash will show them correctly in the right
order
@jbeezley @doutriaux1 @ThomasMaxwell please review