Conversation
on to cleaning vcsvtk
|
@aashish24 @dlonie @sankhesh this one is |
|
Ubuntu dashboard: https://open.cdash.org/viewTest.php?onlypassed&buildid=3907746 |
|
@aashish24 pinging you on this. |
|
@doutriaux1 will review it today. |
|
@doutriaux1 this is good stuff. Thanks for doing this. Minor suggestion: Commit messages could be improved for example "moving along". You can squash these commit messages into some more meaningful so that we can have a good code history. I understand that these messages are typically created during the developement. |
|
@aashish24 you're right, I really need to get going with the squash thing before submitting PRs. Thanks for the merge! |
|
You are welcome my friend. Squash is really useful 😄 |
The test currently fails. The code needs to be cleaned up before merging.
@doutriaux1 @aashish24