Merged
Conversation
This change fixes issue #1405
This change fixes issue #1405
When RPY2 is built against R that does not have readline support, importing rpy2 results in error. readline is listed as a dependency in RPY2's documentation. This change addresses issue #1405
added aqua for mac added openmp for parallel builds disabled -j1 for install step
Contributor
Author
|
Taken over from #1437 @aashish24 @doutriaux1 Please review |
Closed
Contributor
There was a problem hiding this comment.
why do we need this package?
Contributor
There was a problem hiding this comment.
Can we not add this to the list of requirements?
Contributor
There was a problem hiding this comment.
ubuntu needs it, and it's python based so can't be in requirements
Contributor
There was a problem hiding this comment.
@doutriaux1 can you explain bit more on why Ubuntu needs it?
Contributor
There was a problem hiding this comment.
setup.py on ubuntu lists it as a dependeny. So inside our firewall it died because it couldn't fetch it. It's yet another example of the "cool/sneaky" features of pip...
Contributor
There was a problem hiding this comment.
Coo! thanks for the information. Very useful.
- Aashish
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable R and RPY2 support