Merged
Conversation
Member
Author
|
@doutriaux1 just to get this one done and dusted, Do you need any other help with this?
|
Contributor
There was a problem hiding this comment.
@sankhesh we should do that for rpy2, I noticed it doesn't build if BUILD_MODE=ALL
doutriaux1
force-pushed
the
issue1070_durack1_UpdatePyspharm
branch
from
2efbea3 to
7d3075c
Compare
won't wait anymore for y/n download spherepack from our URL
doutriaux1
added a commit
that referenced
this pull request
Jul 28, 2015
Issue1070 durack1 update pyspharm
Member
Author
|
@doutriaux1 thanks for this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@doutriaux1 this updates #1074 to be rebased to current
master(for additional comments take a peek at #1074) -spherepackwill need to be added as a new package andpyspharm_deps.cmakeupdated so it's included as a dependency