Skip to content

Fixed cmake warnings and set appropriate policy#1536

Merged
doutriaux1 merged 2 commits intomasterfrom
fix_cmake_warnings
Sep 10, 2015
Merged

Fixed cmake warnings and set appropriate policy#1536
doutriaux1 merged 2 commits intomasterfrom
fix_cmake_warnings

Conversation

@aashish24
Copy link
Copy Markdown
Contributor

Ref: #1011

@aashish24
Copy link
Copy Markdown
Contributor Author

@doutriaux1 @sankhesh please review.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This policy was introduced in 3.1. Probably should add if(POLICY CMP0054) to support older cmake's.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure @jbeezley. This is a good point. I pushed a change.

@doutriaux1
Copy link
Copy Markdown
Contributor

error not related to this branch, messages are gone, merging in.

doutriaux1 added a commit that referenced this pull request Sep 10, 2015
Fixed cmake warnings and set appropriate policy
@doutriaux1 doutriaux1 merged commit 8527061 into master Sep 10, 2015
@doutriaux1 doutriaux1 deleted the fix_cmake_warnings branch September 10, 2015 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants