Fix view rotation when rendering in background mode

[sankhesh]

Fixes #1446

[sankhesh]

@doutriaux1 @aashish24

[doutriaux1]

@sankhesh fails on mac?

[sankhesh]

@doutriaux1

I think I know the issue. I'll push a fix soon.

[aashish24]

Looks like mac is running into build issues 😢

[aashish24]

CDMS_Test_multiple_formats because of opendap issue.

[doutriaux1]

@sankhesh fails on RH6 w/o MESA

[doutriaux1]

@aashish24 CDMS_Test_multiple_formats is weird it actually set faults on this machine. But it's not related to the regular .dodsrc open dap issue.

[durack1]

@doutriaux1 it's vcs_test_background_mode_rotate on crunchy this time, and vcs_test_click_info on garant

[durack1]

@doutriaux1 looks like Xvfb needs a restart on crunchy

Successfully updated your environment to use UVCDAT
(changes are valid for this session/terminal only)
Version: 2.2.0-538-g1922557
Location: /export/doutriaux1/uvcbot/build/install
failed to create drawable
X Error of failed request:  GLXBadContextTag
  Major opcode of failed request:  149 (GLX)
  Minor opcode of failed request:  5 (X_GLXMakeCurrent)
  Serial number of failed request:  15662
  Current serial number in output stream:  15662)

[durack1]

@doutriaux1 and the same weird issue with graphic output with fills outside of the box border and axis labels (particularly y-axis, see the location of the 90N) also being outside the area of the box - kinda like a box vs canvas offset or similar

The output of the test on garant:

[doutriaux1]

@durack1 this is a new test. I can restart Xvfb but I doubt that's the issue

[doutriaux1]

@sankhesh this does not work the following snippet demonstrates the problem:

import cdms2
import vcs
import os
f=cdms2.open(os.path.join(vcs.sample_data,"clt.nc"))
s=f("clt")
x=vcs.init()
x.portrait()  # turn page in portrait mode
x.portrait()  # turn page in portrait mode (again but it is already in portrait so it should be doing nothing)
x.plot(s)
x.png("test_portrait_bg")

leads to:

Essentially you rotate twice

[doutriaux1]

@sankhesh you might want to add this as a test too if @aashish24 thinks it is a worthy test 😉

[doutriaux1]

@sankhesh I pushed a fix

[doutriaux1]

@sankhesh sorry there is still an issue somewhere:

import vcs
import cdms2
import os

f=cdms2.open(os.path.join(vcs.sample_data,"clt.nc"))
s=f("clt",slice(0,1))
x=vcs.init()
x.plot(s,bg=1)
x.png("landscape")
x.clear()
x.portrait()
x.plot(s,bg=1)
x.png("portrait")

comes out landscape

[durack1]

@doutriaux1 looks like the vcs_addons_* test images might all be broken here?

[sankhesh]

@doutriaux1 @durack1 @aashish24 My latest changes fixed the background_rotate test that was added new in this branch.

[doutriaux1]

@sankhesh does this fix the second script i posted last night

[sankhesh]

@doutriaux1 Yes

[doutriaux1]

@sankhesh your eztemplate png are actually better, can you please add them to the new baselines?

[sankhesh]

@doutriaux1 What do you mean by _better_? All the EzTemplate tests pass on my machine i.e. they generate the same images as the baselines. What am I missing something here?

[aashish24]

@jbeezley when I visit a link to garant in here, it does not show the page I am expected to see. Is that a bug?

[jbeezley]

If the build stage doesn't finish, then the cdash link won't work. You need to look for the build manually. C.f. https://open.cdash.org/viewBuildError.php?buildid=4029068 It is one of the things that would be nice to have an API for in CDash.

[jbeezley]

Actually, I was thinking this was the libx264 PR. It looks like the difference between a "working" link and a "broken" link the =N at the end. I have no idea why the buildbot puts that there or what it is supposed to mean.

https://open.cdash.org/index.php?compare1=65&filtercount=2&field1=buildname%2Fstring&project=UV-CDAT&field2=buildstarttime%2Fdate&showfilters=0&limit=100&compare2=83&value1=f2ee8f46-build1214-uvcdat-garant-linux-release&showfeed=0&display=project&value2=N

https://open.cdash.org/index.php?compare1=65&filtercount=2&field1=buildname%2Fstring&project=UV-CDAT&field2=buildstarttime%2Fdate&showfilters=0&limit=100&compare2=83&value1=f2ee8f46-build1214-uvcdat-garant-linux-release&showfeed=0&display=project&value2

[doutriaux1]

@sankhesh on my Mac running your branch. The pngs are in portrait mode whereas it seems that the baselines png are in landscape. No?

[doutriaux1]

@sankhesh see https://open.cdash.org/viewTest.php?onlyfailed&buildid=4035541

[doutriaux1]

@sankhesh could it be the bit that gets the screen size to determine the window size?

[aashish24]

@doutriaux1 it does looks like that they are in different mode.

[doutriaux1]

@sankhesh should we worry about crunchy failure? Maybe post rc1?

[sankhesh]

@doutriaux1 Not sure why there is a GLX issue on crunchy just for this one test. Any ideas?

I am assuming you are referring to my EzTemplate question about the portrait vs landscape images. Yes, it does seem like your mac is generating portrait images. I think it is related to your latest screensize changes.

[doutriaux1]

@sankhesh all platforms pass. Merging in.