Fix vector plots by aashish24 · Pull Request #1560 · CDAT/cdat

aashish24 · 2015-09-19T22:11:33Z

WIP: I have observed tests failing on my machine but the difference seems small. I just wanted to see how they run on buildbot machine.

aashish24 · 2015-09-19T22:13:09Z

doutriaux1 · 2015-09-21T22:25:00Z

@aashish24 still lots of failures here. What changed?

aashish24 · 2015-09-22T03:44:16Z

@doutriaux1 thats puzzling me. On my machine, I am getting only vector tests failure. Although I am using the patched VTK

aashish24 · 2015-09-22T16:06:40Z

@doutriaux1 still the same. For some reason, I am not seeing these failing tests on my machine.

sankhesh · 2015-09-23T19:27:59Z

data1 could be NoneType

vcs_no_xtra_elts fails because of that. (https://open.cdash.org/testDetails.php?test=375905204&build=4024522)

aashish24 · 2015-09-24T04:26:13Z

@doutriaux1 this branch should be good to now. The problem (failing tests) was with VTK bug. I will fix the doWrap method in another PR.

aashish24 · 2015-09-24T04:40:55Z

Goes with CDAT/uvcdat-testdata#67

doutriaux1 · 2015-09-24T05:23:52Z

@aashish24 waiting for the bots to be done to confirm merge. Thanks for pushing this in.

doutriaux1 · 2015-09-24T05:25:28Z

@aashish24 4 failures on oceanonly, but I think it is because master was merged in by bots.

aashish24 · 2015-09-24T05:36:10Z

Right. there was an issue with the test-data. The only real test failing is test_no_extra_elements

aashish24 · 2015-09-24T15:02:45Z

@doutriaux1 most of the tests are passing now. The multiple format one and label background one is failing for some other reason.

aashish24 · 2015-09-24T16:19:23Z

@doutriaux1 this branch is looking good now. Not sure why the label and the click test is failing.

https://open.cdash.org/testDetails.php?test=376700167&build=4028520

durack1 · 2015-09-24T16:49:34Z

@aashish24 the reason is due to problems with the test image, so compare the baseline:

With the test output:

You'll see that there is bleeding of color outside the box, and the y-axis labels in particular are offset, look at 90N.. There are also problems with the x-axis labels and their placement too..

aashish24 · 2015-09-24T17:02:51Z

@doutriaux1 could it be caused by my changes? thanks @durack1

durack1 · 2015-09-24T17:12:19Z

@aashish24 I've been seeing this issue in a number of PRs #1540, #1560, #1557 - and it only seems to be a problem on garant - so an OS-specific or machine-specific issue?

durack1 · 2015-09-24T17:25:31Z

@aashish24 @doutriaux1 I'm wondering if garant is just not syncing correctly with the updated source and as it's behind we're getting these failures - looks like the case with #1564..

jbeezley · 2015-09-24T17:30:26Z

It doesn't merge in master like the others. Is that the issue?

durack1 · 2015-09-24T17:34:47Z

@jbeezley it seems that in particular with #1564 FFmpeg issues are only occurring on garant, whereas everything else passes.. So like it fails to pull across all the PR changes or something? Dunno?

aashish24 · 2015-09-24T20:25:35Z

thanks @durack1 for the information. In that case, I think this branch looks good to me. Can someone review it @durack1 @sankhesh @jbeezley @chaosphere2112

sankhesh · 2015-09-24T20:32:19Z

This file doesn't comply with PEP8 style.

@sankhesh but I don't see flake8 test failing. what I am missing?

We probably don't check the test scripts.

Ah I see. Thanks @jbeezley. I will push a fix to follow the PEP8 stype in my next branch as I need to take care of doWrap as well.

Fix vector plots

aashish24 · 2015-09-24T20:53:21Z

thanks @doutriaux1

aashish24 force-pushed the fix_vector_plots branch from 4e31235 to a50fe9d Compare September 21, 2015 18:37

aashish24 mentioned this pull request Sep 21, 2015

Fixed wrong index being used. CDAT/VTK#7

Merged

aashish24 force-pushed the fix_vector_plots branch from f3bdc79 to 99ba107 Compare September 22, 2015 03:48

aashish24 force-pushed the master branch from bfe2642 to 3283d6c Compare September 22, 2015 04:19

aashish24 force-pushed the fix_vector_plots branch 5 times, most recently from 3f97702 to 4589d40 Compare September 22, 2015 06:05

sankhesh reviewed Sep 23, 2015
View reviewed changes

aashish24 force-pushed the fix_vector_plots branch from 5040d2f to bd9ae1f Compare September 24, 2015 03:20

aashish24 added 6 commits September 23, 2015 23:23

Fixing vector plots not working for mercator and robinson projection

8f4888e

Fixed rebase conflict error

9c7747c

Clean up

279ddba

Fixed failing vector plot tests

b208764

Fixed flake8 warnings

05ab6ea

Attempt to fix failing dashboard tests

df7ef7b

aashish24 force-pushed the fix_vector_plots branch from bd9ae1f to df7ef7b Compare September 24, 2015 03:23

aashish24 force-pushed the fix_vector_plots branch from a0aecd6 to 5fed2d3 Compare September 24, 2015 04:39

Added test for vector plots using Robinson projection

1ff5fbd

aashish24 force-pushed the fix_vector_plots branch from 5fed2d3 to 1ff5fbd Compare September 24, 2015 04:40

aashish24 force-pushed the fix_vector_plots branch 2 times, most recently from 8693236 to 6e386fa Compare September 24, 2015 05:53

Added check of lat lon presence

7ac099b

aashish24 force-pushed the fix_vector_plots branch from 6e386fa to 7ac099b Compare September 24, 2015 12:48

Fixed one more flake8 warning

a8f6657

durack1 mentioned this pull request Sep 24, 2015

Integrated libx264 for higher quality mp4 output #1564

Merged

sankhesh reviewed Sep 24, 2015
View reviewed changes

doutriaux1 added a commit that referenced this pull request Sep 24, 2015

Merge pull request #1560 from UV-CDAT/fix_vector_plots

7241b33

Fix vector plots

doutriaux1 merged commit 7241b33 into master Sep 24, 2015

aashish24 mentioned this pull request Oct 9, 2015

Fixed doWrap method for vectors #1602

Merged

Conversation

aashish24 commented Sep 19, 2015

WIP: I have observed tests failing on my machine but the difference seems small. I just wanted to see how they run on buildbot machine.

Uh oh!

aashish24 commented Sep 19, 2015

Uh oh!

doutriaux1 commented Sep 21, 2015

Uh oh!

aashish24 commented Sep 22, 2015

Uh oh!

aashish24 commented Sep 22, 2015

Uh oh!

sankhesh Sep 23, 2015

Choose a reason for hiding this comment

Uh oh!

aashish24 commented Sep 24, 2015

Uh oh!

aashish24 commented Sep 24, 2015

Uh oh!

doutriaux1 commented Sep 24, 2015

Uh oh!

doutriaux1 commented Sep 24, 2015

Uh oh!

aashish24 commented Sep 24, 2015

Uh oh!

aashish24 commented Sep 24, 2015

Uh oh!

aashish24 commented Sep 24, 2015

Uh oh!

durack1 commented Sep 24, 2015

Uh oh!

aashish24 commented Sep 24, 2015

Uh oh!

durack1 commented Sep 24, 2015

Uh oh!

durack1 commented Sep 24, 2015

Uh oh!

jbeezley commented Sep 24, 2015

Uh oh!

durack1 commented Sep 24, 2015

Uh oh!

aashish24 commented Sep 24, 2015

Uh oh!

sankhesh Sep 24, 2015

Choose a reason for hiding this comment

Uh oh!

aashish24 Sep 24, 2015

Choose a reason for hiding this comment

Uh oh!

jbeezley Sep 24, 2015

Choose a reason for hiding this comment

Uh oh!

aashish24 Sep 24, 2015

Choose a reason for hiding this comment

Uh oh!

aashish24 commented Sep 24, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants