Issue 1347 use screensize by aashish24 · Pull Request #1563 · CDAT/cdat

aashish24 · 2015-09-22T04:29:21Z

No description provided.

using this feature and reintroducing use to size keyword in vcs.init() fix #1347

…ensize Conflicts: testing/vcs/CMakeLists.txt

##bot##skip-commit

…ensize

durack1 · 2015-09-22T16:02:35Z

@aashish24 it seems that garant is having some problems, it's failed here and also on #1540..

aashish24 · 2015-09-22T16:07:36Z

@doutriaux1 looks like one test is failing. Although I don't know how its related to your change.

durack1 · 2015-09-22T16:12:09Z

@aashish24 as noted above it seems that garant is having configuration problems, rather than failing the ctest suite..

jbeezley · 2015-09-22T16:14:58Z

Not sure the issue, but this is the cmake output:

CMake Error: Error in cmake code at
/home/buildbot/buildbot/uvcdat-garant-linux-release/source/testing/vcs/CMakeLists.txt:35:
Parse error.  Expected a command name, got quoted argument with text "${PYTHON_EXECUTABLE}".
[INFO] You did not download UVCMETRICS Test data not test will be run
-- Configuring incomplete, errors occurred!

jbeezley · 2015-09-22T16:20:25Z

There is definitely a syntax error at that line. I'm not sure why it isn't failing on the other machines.

doutriaux1 · 2015-09-22T16:20:52Z

@jbeezley fixing now. Thx for spotting.

aashish24 · 2015-09-22T16:21:07Z

@jbeezley I pushed a fix

doutriaux1 · 2015-09-22T16:21:49Z

@aashish24 you beat me to it. Thx.

aashish24 · 2015-09-22T16:23:34Z

😸

aashish24 · 2015-09-22T16:50:29Z

@doutriaux1 we are getting this:

self.__plot(arglist, keyargs)
File "/home/buildbot/buildbot/uvcdat-garant-linux-release/build/install/lib/python2.7/site-packages/vcs/Canvas.py", line 3839, in __plot
returned_kargs = self.backend.plot(_arglist, _keyargs)
File "/home/buildbot/buildbot/uvcdat-garant-linux-release/build/install/lib/python2.7/site-packages/vcs/VTKPlots.py", line 445, in plot
self.createRenWin(kargs)
File "/home/buildbot/buildbot/uvcdat-garant-linux-release/build/install/lib/python2.7/site-packages/vcs/VTKPlots.py", line 314, in createRenWin
self.initialSize()
File "/home/buildbot/buildbot/uvcdat-garant-linux-release/build/install/lib/python2.7/site-packages/vcs/VTKPlots.py", line 412, in initialSize
bgX = int(screenSize[0].6)
TypeError: can't multiply sequence by non-int of type 'float'

aashish24 · 2015-09-22T16:50:43Z

Looks like VTK still giving us a pointer.

doutriaux1 · 2015-09-22T18:06:01Z

did that got reverted? I works in what uvcdat-master we had last week.

doutriaux1 · 2015-09-22T18:59:06Z

@aashish24 garant seems to be hosed?

doutriaux1 · 2015-09-22T21:14:48Z

@aashish24 why are travis builds suddenly failing because of wrong version of cmake?

doutriaux1 · 2015-09-22T23:58:27Z

now goes with: CDAT/uvcdat-testdata#66

ctest -D Experimental on bots detached head reverts to master always

##bot##cmake_xtra -DCDAT_CHECKOUT_BASELINE_MATCHING_BRANCH=OFF

doutriaux1 · 2015-09-23T06:08:42Z

@aashish24 @jbeezley no matter what ctest -D Experimental switch the branch back to master sooooo annoying....

doutriaux1 · 2015-09-23T13:50:57Z

@aashish24 @jbeezley why does ctest resets the branch to master!

aashish24 · 2015-09-23T17:33:04Z

What's changed?

indentation, it's now in an if loop

doutriaux1 · 2015-09-23T17:53:29Z

@aashish24 @jbeezley I got it! RH6 FULL is passing! Retriggering it on all machines now.

aashish24 · 2015-09-23T17:54:16Z

what was the issue?

doutriaux1 · 2015-09-23T17:57:15Z

xtra cmake args from commit were not parsed correctly by bot slaves

doutriaux1 · 2015-09-23T17:57:56Z

I updated the slaves to send the command all the time, this latest commit doesn't send any extra args to slaves so we will see if the system works properly now.

doutriaux1 · 2015-09-23T19:34:40Z

@aashish24 we need this to test all pending branches with new baselines please approve quick.

@aashish24

Issue 1347 use screen size Can't wait any longer @aashish24 merging, we really needs this in in order to move forward for the rc. fix #1347

doutriaux1 and others added 6 commits September 14, 2015 11:15

now that VTK returns actual screensize let's use it

3305c2e

VTK let us get screen size again from python

1f6c9c2

using this feature and reintroducing use to size keyword in vcs.init() fix #1347

Added rational behind the numbers

7d8cc9a

Merge remote-tracking branch 'origin/master' into issue_1347_use_scre…

36c322c

…ensize Conflicts: testing/vcs/CMakeLists.txt

Added a few comments

48618c4

##bot##skip-commit

Merge remote-tracking branch 'origin/master' into issue_1347_use_scre…

122c4dd

…ensize

Fixed test declaration

f7f1519

test was in wrong path

f4e3c2e

doutriaux1 added 2 commits September 22, 2015 16:02

test that were opening a window needed to be given a geometry

a7d4596

verify size passes, somehow VTK broken partially

c3bb0c5

doutriaux1 added 5 commits September 22, 2015 20:56

Added keyword to turn off baseline branch matching magic

d870b8e

ctest -D Experimental on bots detached head reverts to master always

flake8ed

dd7c0a4

made the branch magic flag a cmake option

24ae3f0

##bot##cmake_xtra -DCDAT_CHECKOUT_BASELINE_MATCHING_BRANCH=OFF

correct cmake syntax to turn on/off magic flag

7d31948

##bot##cmake_xtra -DCDAT_CHECKOUT_BASELINE_MATCHING_BRANCH=OFF

I think I finally commented out enough...

f1bb222

##bot##cmake_xtra -DCDAT_CHECKOUT_BASELINE_MATCHING_BRANCH=OFF

doutriaux1 force-pushed the issue_1347_use_screensize branch from d049702 to f1bb222 Compare September 23, 2015 16:52

moved message at begining of if section rather than in the middle of it

7eb4929

aashish24 reviewed Sep 23, 2015
View reviewed changes

doutriaux1 added a commit that referenced this pull request Sep 23, 2015

Merge pull request #1563 from UV-CDAT/issue_1347_use_screensize

e1e4f40

Issue 1347 use screen size Can't wait any longer @aashish24 merging, we really needs this in in order to move forward for the rc. fix #1347

doutriaux1 merged commit e1e4f40 into master Sep 23, 2015

doutriaux1 deleted the issue_1347_use_screensize branch September 23, 2015 20:56

jbeezley mentioned this pull request Oct 27, 2015

Animations will properly resume when resizing #1634

Merged

Conversation

aashish24 commented Sep 22, 2015

Uh oh!

durack1 commented Sep 22, 2015

Uh oh!

aashish24 commented Sep 22, 2015

Uh oh!

durack1 commented Sep 22, 2015

Uh oh!

jbeezley commented Sep 22, 2015

Uh oh!

jbeezley commented Sep 22, 2015

Uh oh!

doutriaux1 commented Sep 22, 2015

Uh oh!

aashish24 commented Sep 22, 2015

Uh oh!

doutriaux1 commented Sep 22, 2015

Uh oh!

aashish24 commented Sep 22, 2015

Uh oh!

aashish24 commented Sep 22, 2015

Uh oh!

aashish24 commented Sep 22, 2015

Uh oh!

doutriaux1 commented Sep 22, 2015

Uh oh!

doutriaux1 commented Sep 22, 2015

Uh oh!

doutriaux1 commented Sep 22, 2015

Uh oh!

doutriaux1 commented Sep 22, 2015

Uh oh!

doutriaux1 commented Sep 23, 2015

Uh oh!

doutriaux1 commented Sep 23, 2015

Uh oh!

aashish24 Sep 23, 2015

Choose a reason for hiding this comment

Uh oh!

doutriaux1 Sep 23, 2015

Choose a reason for hiding this comment

Uh oh!

doutriaux1 commented Sep 23, 2015

Uh oh!

aashish24 commented Sep 23, 2015

Uh oh!

doutriaux1 commented Sep 23, 2015

Uh oh!

doutriaux1 commented Sep 23, 2015

Uh oh!

doutriaux1 commented Sep 23, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants