Merged
Conversation
Do not pass patterning arguments to legend fillarea when using non-custom boxfill types. Fixes #1577
Contributor
|
@sankhesh seems to be failing |
Contributor
Author
|
@doutriaux1 Tests are passing now. The remaining failures are due to uvcdat-testdata not being fetched from the right branch on the dashboard machines. Not sure what is the reason. |
Contributor
|
@doutriaux1 @sankhesh are we good with this branch then? |
Contributor
Author
|
Yes. Needs review and merge. |
Contributor
|
yes we are good but I want to figure out why the baselines are not checked out anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1577
Baselines added in CDAT/uvcdat-testdata#71