Merged
Conversation
Contributor
|
@sankhesh we need to tell flake8 to accept line up to 120 characters. |
Contributor
|
@sankhesh also can you please move the files in Test into the testing directory the nc file should go in uvcdat-testdata/data/Thermo or something similar, look at my WK branch. Thx. |
Contributor
Author
|
@doutriaux1 Sure thing. |
Contributor
Author
|
@doutriaux1 Looking at your WK branch to make similar changes to Thermo. I see that you moved the EDIT: |
Contributor
Author
|
@doutriaux1 Thermo testing changes are in the thermo_testing branch. |
Contributor
Author
|
@doutriaux1 All tests are passing here. Needs review and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1416