Conversation
|
@chaosphere2112 yep that's what I was suspecting you probably need to update the md5 |
|
@doutriaux1 @dnadeau4 Sorry about that, just wanted to push the PR out before I went home for the day. Fixed both of those issues. |
There was a problem hiding this comment.
So X264_deps just depends on pkgconfig? Are there any other system specific libraries we need to document?
There was a problem hiding this comment.
Nope; in fact, it technically doesn't even depend on pkgconfig. It has a soft dependency on yasm, but that's already sort of a dependency for us (as part of the original x264 PR I did some stuff to make our build handle not having yasm installed).
There was a problem hiding this comment.
The reason it's "dependent" on pkgconfig is because it fixes a weird parallelism issue that @dnadeau4 was having (where the linker got confused as libx264 and pkgconfig built at the same time).
There was a problem hiding this comment.
thanks @chaosphere2112.care to add a note in the deps file so that someone know it next time?
|
No problem @chaosphere2112 thanks for addressing our suggestions. Once cdash is happy, I will give it +2 |
|
@doutriaux1 Those have been stuck in queue an awfully long time... any idea on the status? |
|
I killed the server, I need to restart it. |
4 participants
Fixes a few bugs...
#1586
@doutriaux1's issue with expanding x264 on a newer CMake
@dnadeau4's issue with building x264 on his VM