fix #1281 default marker size too small#1617
Merged
Conversation
also let the marker size by any positive number so if users find it too big they can make it smaller
Contributor
Author
|
@aashish24 @sankhesh @chaosphere2112 after the bots are done please review |
Contributor
There was a problem hiding this comment.
Why not make it a integer number say 10, 20? it may help if we are going to do pixel align rendering.
Contributor
Author
There was a problem hiding this comment.
I was looking at numbers with a scientist, 3 wasn't right and 4 too big. So I made it fun. Beside s is not an integer to start with.
Contributor
There was a problem hiding this comment.
I was looking at numbers with a scientist, 3 wasn't right and 4 too big. So I made it fun. Beside s is not an integer to start with.
I see. I am bit surprised that s is not an integer.
Contributor
|
other than that it LGTM 👍 |
aashish24
added a commit
that referenced
this pull request
Oct 16, 2015
fix #1281 default marker size too small
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also let the marker size by any positive number so if users find it too big they can make it smaller