Merged
Conversation
Contributor
|
@chaosphere2112 flake8_vcs is failing.. |
fix flake8?
Contributor
|
@chaosphere2112 @doutriaux1 lot of tests are failing on Linux-RH6. Looking into it. |
Contributor
|
@doutriaux1 could it be because of VTK SHA (wrong one) |
Contributor
There was a problem hiding this comment.
that's essentially what the old code was doing, why the more complicated lines?
Contributor
Author
There was a problem hiding this comment.
Because width and height are always passed into this function by the caller, though most of the time they are None.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a test for initial sizing of window (you can pass a
geometrykwarg to vcs.init to specify window dimensions), and fixed some issues with the logic. Also tests to make sureopen(width=X, height=X)works properly.