Add test for issue #1106: Continents are off.#1717
Merged
doutriaux1 merged 2 commits intomasterfrom Dec 10, 2015
Merged
Conversation
Contributor
Author
|
@sankhesh @doutriaux1 @aashish24 Please review |
Contributor
There was a problem hiding this comment.
@danlipsa It would be good if new code followed PEP8 convention.
In this case, there should be a space after the comma.
Contributor
There was a problem hiding this comment.
the pep8 police 😉 I'm with you @danlipsa "vive la resistance"
The fix for this issue is at 658ac44.
danlipsa
force-pushed
the
continents-off-test
branch
from
a94f4fa to
ce8956a
Compare
Contributor
Author
|
@sankhesh @doutriaux1 I have addressed all comments. |
Contributor
|
thx @danlipsa did you also update the baseline with the not antialiased pix? |
Contributor
|
@doutriaux1 does n't look like it. I am going to upload a new baseline. |
Contributor
Author
|
@doutriaux1 @aashish24 I did upload the larger file, which I think is also not antialiased. |
Contributor
Author
|
@doutriaux1 @aashish24 is this ready? |
Contributor
Author
|
@aashish24 @doutriaux1 Can we merge this? |
doutriaux1
added a commit
that referenced
this pull request
Dec 10, 2015
Add test for issue #1106: Continents are off.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix for this issue is at 658ac44.