Conversation
updated shapely and gdal to latest versions
moade it so that it builds only when turned on (-DCDAT_BUILD_OCGIS=ON) added directory for ocgis testing (only import for now)
fix test name and location
|
@doutriaux1 looks like the |
|
@aashish24 @danlipsa @sankhesh @chaosphere2112 this is ready to go in. It will help with proj4 upgrade as well since it builds proj4. |
|
Yay!! |
|
@doutriaux1 @aashish24 What other library is using proj4 besides VTK? |
There was a problem hiding this comment.
@aashish24 I think that bit here tells pipinstaller if we want it to use the --old-and-unmanageable option in setup.py which contrarily to what its name says make parallel build manageable...
|
@danlipsa OCGIS is using proj4 which is why I put it in in the first place (here) |
|
@doutriaux1 Makes sense. |
|
@doutriaux1 I am building this will let you know how it goes. |
|
@doutriaux1 everything LGTM |
|
@doutriaux1 just need to update the branch with current master. If all goes well, I will merge it. |
|
thanks @aashish24 but did you build with -DCDAT_BUILD_OCGIS=ON ? otherwise I don't think it makes any difference. |
|
I built with both -DCDAT_BUILD_OCGIS=ON and -DCDAT_BUILD_OCGIS=OFF and both worked for me 👍 |
|
Great! |
|
@doutriaux1 ENUM stuff is failing. |
|
odd... but easy enough to fix, thanks will push a fix soon |
|
@doutriaux1 I guess you didn't get time to push a fix? |
|
you're right... |
|
@doutriaux1 do you want me to look into it? |
|
If you have time that would be great! |
|
Thanks! @aashish24 |
|
@doutriaux1 we skip egg installation because....? Can you remind me please. |
|
@aashish24 one reason is that when building using more than one thread, the |
@durack1 we avoid that by making sure that dependencies are set such that only one pip packages gets installed at any given time. |
Conflicts: CMakeLists.txt
|
@doutriaux1 I believe I fixed all the issues and resolved the merge conflicts. Once the dashboard runs, I will merge this branch. |
|
@doutriaux1 please have a look at my changes and if looks good, merge it (not sure if you want run it on your local machine). |
|
@doutriaux1 tests failing cannot be related to this branch and since this is your branch originally, I am going to merge it as it LGTM 👍 |
@aashish24 can you please take a look at this branch and add the bits to get VTK to use our proj4 to it.
Thanks.