Skip to content

Ocgis#1729

Merged
aashish24 merged 28 commits intomasterfrom
ocgis
Mar 24, 2016
Merged

Ocgis#1729
aashish24 merged 28 commits intomasterfrom
ocgis

Conversation

@doutriaux1
Copy link
Copy Markdown
Contributor

@aashish24 can you please take a look at this branch and add the bits to get VTK to use our proj4 to it.

Thanks.

@durack1
Copy link
Copy Markdown
Member

durack1 commented Dec 10, 2015

@doutriaux1 looks like the bots have hung again.. Might need a restart across the bot-grid

@doutriaux1
Copy link
Copy Markdown
Contributor Author

@aashish24 @danlipsa @sankhesh @chaosphere2112 this is ready to go in. It will help with proj4 upgrade as well since it builds proj4.

@aashish24
Copy link
Copy Markdown
Contributor

Yay!!

@danlipsa
Copy link
Copy Markdown
Contributor

danlipsa commented Feb 2, 2016

@doutriaux1 @aashish24 What other library is using proj4 besides VTK?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@doutriaux1 can you add some comment here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aashish24 I think that bit here tells pipinstaller if we want it to use the --old-and-unmanageable option in setup.py which contrarily to what its name says make parallel build manageable...

@doutriaux1
Copy link
Copy Markdown
Contributor Author

@danlipsa OCGIS is using proj4 which is why I put it in in the first place (here)

@danlipsa
Copy link
Copy Markdown
Contributor

danlipsa commented Feb 2, 2016

@doutriaux1 Makes sense.

@aashish24
Copy link
Copy Markdown
Contributor

@doutriaux1 I am building this will let you know how it goes.

@aashish24
Copy link
Copy Markdown
Contributor

@doutriaux1 everything LGTM

@aashish24
Copy link
Copy Markdown
Contributor

@doutriaux1 just need to update the branch with current master. If all goes well, I will merge it.

@doutriaux1
Copy link
Copy Markdown
Contributor Author

thanks @aashish24 but did you build with -DCDAT_BUILD_OCGIS=ON ? otherwise I don't think it makes any difference.

@aashish24
Copy link
Copy Markdown
Contributor

I built with both -DCDAT_BUILD_OCGIS=ON and -DCDAT_BUILD_OCGIS=OFF and both worked for me 👍

@doutriaux1
Copy link
Copy Markdown
Contributor Author

Great!

@aashish24
Copy link
Copy Markdown
Contributor

@doutriaux1 ENUM stuff is failing.

@doutriaux1
Copy link
Copy Markdown
Contributor Author

odd... but easy enough to fix, thanks will push a fix soon

@aashish24
Copy link
Copy Markdown
Contributor

@doutriaux1 I guess you didn't get time to push a fix?

@doutriaux1
Copy link
Copy Markdown
Contributor Author

you're right...

@aashish24
Copy link
Copy Markdown
Contributor

@doutriaux1 do you want me to look into it?

@doutriaux1
Copy link
Copy Markdown
Contributor Author

If you have time that would be great!

@doutriaux1
Copy link
Copy Markdown
Contributor Author

Thanks! @aashish24

@aashish24
Copy link
Copy Markdown
Contributor

@doutriaux1 we skip egg installation because....? Can you remind me please.

@durack1
Copy link
Copy Markdown
Member

durack1 commented Mar 23, 2016

@aashish24 one reason is that when building using more than one thread, the easy_install.pth file isn't locked and so installs get garbled as concurrent writes lead to packages not being listed

@aashish24
Copy link
Copy Markdown
Contributor

@aashish24 one reason is that when building using more than one thread, the easy_install.pth file isn't locked and so installs get garbled as concurrent writes lead to packages not being listed

@durack1 we avoid that by making sure that dependencies are set such that only one pip packages gets installed at any given time.

@aashish24
Copy link
Copy Markdown
Contributor

@doutriaux1 I believe I fixed all the issues and resolved the merge conflicts. Once the dashboard runs, I will merge this branch.

@aashish24
Copy link
Copy Markdown
Contributor

@doutriaux1 please have a look at my changes and if looks good, merge it (not sure if you want run it on your local machine).

@aashish24
Copy link
Copy Markdown
Contributor

@doutriaux1 tests failing cannot be related to this branch and since this is your branch originally, I am going to merge it as it LGTM 👍

@aashish24 aashish24 merged commit a6aaafe into master Mar 24, 2016
@aashish24 aashish24 deleted the ocgis branch March 24, 2016 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants